All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix an example of scatterlists handling in DMA-API.txt
@ 2008-09-18 16:29 FUJITA Tomonori
  2008-09-18 16:35 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: FUJITA Tomonori @ 2008-09-18 16:29 UTC (permalink / raw)
  To: linux-kernel; +Cc: James.Bottomley, jens.axboe

This example isn't the proper way to handle scatterlists (can't handle
sg chaining).

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
 Documentation/DMA-API.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/DMA-API.txt b/Documentation/DMA-API.txt
index d8b63d1..b8e8646 100644
--- a/Documentation/DMA-API.txt
+++ b/Documentation/DMA-API.txt
@@ -337,7 +337,7 @@ With scatterlists, you use the resulting mapping like this:
 	int i, count = dma_map_sg(dev, sglist, nents, direction);
 	struct scatterlist *sg;
 
-	for (i = 0, sg = sglist; i < count; i++, sg++) {
+	for_each_sg(sglist, sg, count, i) {
 		hw_address[i] = sg_dma_address(sg);
 		hw_len[i] = sg_dma_len(sg);
 	}
-- 
1.5.4.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fix an example of scatterlists handling in DMA-API.txt
  2008-09-18 16:29 [PATCH] fix an example of scatterlists handling in DMA-API.txt FUJITA Tomonori
@ 2008-09-18 16:35 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-09-18 16:35 UTC (permalink / raw)
  To: FUJITA Tomonori; +Cc: linux-kernel, James.Bottomley

On Fri, Sep 19 2008, FUJITA Tomonori wrote:
> This example isn't the proper way to handle scatterlists (can't handle
> sg chaining).

Woops, good catch. Applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-18 16:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-18 16:29 [PATCH] fix an example of scatterlists handling in DMA-API.txt FUJITA Tomonori
2008-09-18 16:35 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.