[lm-sensors] [PATCH] hwmon: (it87) Fix fan tachometer reading in

[lm-sensors] [PATCH] hwmon: (it87) Fix fan tachometer reading in

[Andrew Paprocki]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J).
The driver was incorrectly attempting to enable 16-bit fan
readings on rev 0x7 (I) which led to incorrect RPM values.

Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
Tested-by: John Gumb <john.gumb@tandberg.com>
---
 drivers/hwmon/it87.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

[-- Attachment #2: 0001-hwmon-it87-Fix-fan-tachometer-reading-in-IT8712F.patch --]
[-- Type: application/octet-stream, Size: 1356 bytes --]

From b0604f42436514362f6b58df57cefd004e963902 Mon Sep 17 00:00:00 2001
From: Andrew Paprocki <andrew@ishiboo.com>
Date: Tue, 16 Sep 2008 23:47:19 -0400
Subject: [PATCH] hwmon: (it87) Fix fan tachometer reading in IT8712F rev 0x7 (I)

The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J).
The driver was incorrectly attempting to enable 16-bit fan
readings on rev 0x7 (I) which led to incorrect RPM values.

Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
Tested-by: John Gumb <john.gumb@tandberg.com>
---
 drivers/hwmon/it87.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 30cdb09..f113308 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -273,10 +273,10 @@ struct it87_data {
 static inline int has_16bit_fans(const struct it87_data *data)
 {
 	/* IT8705F Datasheet 0.4.1, 3h == Version G.
-	   IT8712F Datasheet 0.9.1, section 8.3.5 indicates 7h == Version I.
+	   IT8712F Datasheet 0.9.1, section 8.3.5 indicates 8h == Version J.
 	   These are the first revisions with 16bit tachometer support. */
 	return (data->type == it87 && data->revision >= 0x03)
-	    || (data->type == it8712 && data->revision >= 0x07)
+	    || (data->type == it8712 && data->revision >= 0x08)
 	    || data->type == it8716
 	    || data->type == it8718;
 }
-- 
1.5.6


[-- Attachment #3: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (it87) Fix fan tachometer reading

[Jean Delvare]

On Tue, 16 Sep 2008 23:55:11 -0400, Andrew Paprocki wrote:
> The IT8712F v0.9.1 datasheet applies to revisions >= 0x8 (J).
> The driver was incorrectly attempting to enable 16-bit fan
> readings on rev 0x7 (I) which led to incorrect RPM values.
> 
> Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
> Tested-by: John Gumb <john.gumb@tandberg.com>
> ---
>  drivers/hwmon/it87.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Patch added to my hwmon tree, thank you. I'll send it to Linus shortly.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors