All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Felipe Balbi <me@felipebalbi.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"George G. Davis" <gdavis@mvista.com>, Alan Cox <alan@redhat.com>,
	Felipe Balbi <felipe.balbi@nokia.com>
Subject: How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync linux-omap changes)
Date: Tue, 23 Sep 2008 13:22:00 +0300	[thread overview]
Message-ID: <20080923102159.GD5102@atomide.com> (raw)
In-Reply-To: <20080923083915.GS22550@infomag.infomag.iguana.be>

* Wim Van Sebroeck <wim@iguana.be> [080923 11:39]:
> Hi Russell,
> 
> > It's unused, but it's a minor point, something that shouldn't stand
> > in the way of it going into the watchdog tree.  It doesn't cause a
> > build error and doesn't cause malfunction.  It's just a little untidy
> > and can be addressed separately.
> 
> We will need to address it later then. I just added the patches to the
> linux-2.6-watchdog-mm tree.
> 
> > +               omap_wdt_set_timeout(wdev);
> > +               omap_wdt_enable(wdev);
> >                 spin_unlock(&wdt_lock);
> > +
> > +               omap_wdt_ping(wdev);
> > 
> > which is moving omap_wdt_ping() outside of the spin lock, which I
> > doubt actually causes any problem in real life on OMAP platforms.
> > Granted that theoretically and logically it's wrong.
> 
> And since this is indeed wrong, I changed this back.

Wim, while at it, here's a related omap_wdt question:

Some omap devices like Nokia 770, N800 and N810 have also a secondary
watchdog on the retu chip connected via cbus. This watchdog needs
to be kicked as it cannot be disabled.

We've been thinking of adding a function that omap_wdt can
call to also kick retu_wdt too as there is only one wdt interface.

Is there some better solution available?

Regards,

Tony

  reply	other threads:[~2008-09-23 10:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20  1:14 [PATCH 0/3] omap watchdog updates Felipe Balbi
2008-09-20  1:14 ` [PATCH 1/3] watchdog: sync linux-omap changes Felipe Balbi
2008-09-20  1:14   ` [PATCH 2/3] watchdog: another ioremap() fix Felipe Balbi
2008-09-20  1:14     ` [PATCH 3/3] watchdog: cleanup a bit omap_wdt.c Felipe Balbi
2008-09-22 18:22   ` [PATCH 1/3] watchdog: sync linux-omap changes Wim Van Sebroeck
2008-09-22 19:13     ` Russell King - ARM Linux
2008-09-23  8:39       ` Wim Van Sebroeck
2008-09-23 10:22         ` Tony Lindgren [this message]
2008-09-23 10:39           ` How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync linux-omap changes) Alan Cox
2008-09-23 11:19           ` Wim Van Sebroeck
2008-09-23 11:32             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923102159.GD5102@atomide.com \
    --to=tony@atomide.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@redhat.com \
    --cc=felipe.balbi@nokia.com \
    --cc=gdavis@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=me@felipebalbi.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.