All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Felipe Balbi <me@felipebalbi.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"George G. Davis" <gdavis@mvista.com>, Alan Cox <alan@redhat.com>,
	Felipe Balbi <felipe.balbi@nokia.com>
Subject: Re: How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync linux-omap changes)
Date: Tue, 23 Sep 2008 14:32:16 +0300	[thread overview]
Message-ID: <20080923113210.GM5102@atomide.com> (raw)
In-Reply-To: <20080923111954.GU22550@infomag.infomag.iguana.be>

* Wim Van Sebroeck <wim@iguana.be> [080923 14:20]:
> Hi Tony,
> 
> > Wim, while at it, here's a related omap_wdt question:
> > 
> > Some omap devices like Nokia 770, N800 and N810 have also a secondary
> > watchdog on the retu chip connected via cbus. This watchdog needs
> > to be kicked as it cannot be disabled.
> > 
> > We've been thinking of adding a function that omap_wdt can
> > call to also kick retu_wdt too as there is only one wdt interface.
> > 
> > Is there some better solution available?
> 
> Plan is to go to a uniform watchdog driver first, then add sysfs
> capabilities and then we can add more devices via sysfs.
> For the time being: I would kick both of them at the same time
> via the /dev/watchdog interface.

Looks like we also need to do this for the twl4030 I2C companion chip
on omap 2430 and 34xx.

So we'll do something like this for now then:

static void omap_wdt_ping(struct omap_wdt_dev *wdev)
{

...

    retu_wdt_ping(wdev);
    twl4030_wdt_ping(wdev);
    
...

}

Then have retu_wdt_ping() and twl4030_wdt_ping() functions defined as
empty static inline functions if not enabled.

Thanks Alan & Wim.

Tony

      reply	other threads:[~2008-09-23 11:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20  1:14 [PATCH 0/3] omap watchdog updates Felipe Balbi
2008-09-20  1:14 ` [PATCH 1/3] watchdog: sync linux-omap changes Felipe Balbi
2008-09-20  1:14   ` [PATCH 2/3] watchdog: another ioremap() fix Felipe Balbi
2008-09-20  1:14     ` [PATCH 3/3] watchdog: cleanup a bit omap_wdt.c Felipe Balbi
2008-09-22 18:22   ` [PATCH 1/3] watchdog: sync linux-omap changes Wim Van Sebroeck
2008-09-22 19:13     ` Russell King - ARM Linux
2008-09-23  8:39       ` Wim Van Sebroeck
2008-09-23 10:22         ` How to kick a secondary watchdog? (Re: [PATCH 1/3] watchdog: sync linux-omap changes) Tony Lindgren
2008-09-23 10:39           ` Alan Cox
2008-09-23 11:19           ` Wim Van Sebroeck
2008-09-23 11:32             ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080923113210.GM5102@atomide.com \
    --to=tony@atomide.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@redhat.com \
    --cc=felipe.balbi@nokia.com \
    --cc=gdavis@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=me@felipebalbi.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.