Re: [PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues

[Amit Shah <amit.shah@redhat.com>]

* On Tuesday 23 Sep 2008 21:43:44 Anthony Liguori wrote:
> Amit Shah wrote:
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> > ---
> >  qemu/hw/isa.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/qemu/hw/isa.h b/qemu/hw/isa.h
> > index 222e4f3..e4a1326 100644
> > --- a/qemu/hw/isa.h
> > +++ b/qemu/hw/isa.h
> > @@ -2,6 +2,8 @@
> >  #define HW_ISA_H
> >  /* ISA bus */
> >
> > +#include "hw.h"
> > +
> >  extern target_phys_addr_t isa_mem_base;
> >
> >  int register_ioport_read(int start, int length, int size,
>
> What compile issues?

register_ioport_read* and register_ioport_write* functions cause a lot of 
this.

gcc -I. -I.. -I/home/amit/src/kvm-userspace/qemu/target-i386 -I/home/amit/src/kvm-userspace/qemu -MMD -MT 
device-assignment.o -MP -DNEED_CPU_H -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D__user= -I/home/amit/src/kvm-userspace/qemu/tcg -I/home/amit/src/kvm-userspace/qemu/tcg/x86_64 -I/home/amit/src/kvm-userspace/qemu/fpu  -DHAS_AUDIO -DHAS_AUDIO_CHOICE -I/home/amit/src/kvm-userspace/qemu/slirp -I /home/amit/src/kvm-userspace/qemu/../libkvm  -DCONFIG_X86 -O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels -Wwrite-strings  -m64 -I /home/amit/src/kvm-userspace/kernel/include -c -o 
device-assignment.o /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c
In file included from /home/amit/src/kvm-userspace/qemu/hw/pci.h:6,
                 
from /home/amit/src/kvm-userspace/qemu/hw/device-assignment.h:34,
                 
from /home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:32:
/home/amit/src/kvm-userspace/qemu/hw/isa.h:8: error: expected declaration 
specifiers or â...â before âIOPortReadFuncâ
/home/amit/src/kvm-userspace/qemu/hw/isa.h:10: error: expected declaration 
specifiers or â...â before âIOPortWriteFuncâ
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c: In function 
âassigned_dev_ioport_mapâ:
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:193: error: too many 
arguments to function âregister_ioport_readâ
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:195: error: too many 
arguments to function âregister_ioport_readâ
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:197: error: too many 
arguments to function âregister_ioport_readâ
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:199: error: too many 
arguments to function âregister_ioport_writeâ
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:201: error: too many 
arguments to function âregister_ioport_writeâ
/home/amit/src/kvm-userspace/qemu/hw/device-assignment.c:203: error: too many 
arguments to function âregister_ioport_writeâ
make[2]: *** [device-assignment.o] Error 1
make[2]: Leaving directory `/home/amit/src/kvm-userspace/qemu/x86_64-softmmu'
make[1]: *** [subdir-x86_64-softmmu] Error 2
make[1]: Leaving directory `/home/amit/src/kvm-userspace/qemu'
make: *** [qemu] Error 2