Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <felipe.balbi@nokia.com> [080924 13:45]:
> On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote:
> > On Tuesday 23 September 2008, Koen Kooi wrote:
> > > >>
> > > >> The clean fix requires twl4030 to be a "new style" driver.
> > > >> Fix not yet available. :(
> > > >
> > > > Pushing until we have a better fix.
> > > 
> > > But twl4030 now is a "new style" driver, so we have a start :)
> > 
> > But who's working on it?  :)
> > 
> > Sketch of solution:
> > 
> >  - twl4030.h defines keypad platform_data
> > 
> >  - add_children() adds a platform device for keypad,
> >    and passes that platform_data
> > 
> >  - twl4030 keypad driver switches to platform_bus
> >    and uses that platform_data
> > 
> >  - board-specific init code provides the relevant
> >    platform_data (or none)
> > 
> > I'll do the GPIO code, which will be a slightly more
> > interesting example than the RTC.
> 
> I can do the keypad since I'm already working on the usb as well. Dave,
> I'm gonna add twl_has_rtc(), twl_had_keypad() and twl_has_usb() to clean
> a bit add_children. With those, we're gonna be able to:
> 
> if (twl_has_keypad() && pdata->keypad) {
> 	...
> }

Meanwhile I'll put together some patches for Jean to sync i2c_omap.c.

Tony