From: David Brownell <david-b@pacbell.net>
To: me@felipebalbi.com
Cc: felipe.balbi@nokia.com, Koen Kooi <k.kooi@student.utwente.nl>,
"linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix
Date: Wed, 24 Sep 2008 16:24:29 -0700 [thread overview]
Message-ID: <200809241624.30071.david-b@pacbell.net> (raw)
In-Reply-To: <20080924224413.GJ10156@frodo>
On Wednesday 24 September 2008, Felipe Balbi wrote:
>
> > > if (twl_has_keypad() && pdata->keypad) {
> > > ...
> > > }
> >
> > Sounds good. Fault handling might need attention too.
>
> Sure, think I was thinking that in case in run out of memory I'm gonna
> stop trying to add any more children but leaving the ones we could
> create up and running. What do you think ?
Pretty much my conclusion: report the problem, but continue.
In fact there's no point in returning error codes from that
routine...
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-09-24 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 6:51 [PATCH] OMAP3EVM: TWL4030 Keypad irq error fix arun c
2008-09-20 11:24 ` Felipe Balbi
2008-09-20 17:22 ` David Brownell
2008-09-23 11:00 ` Tony Lindgren
2008-09-23 11:37 ` Koen Kooi
2008-09-23 19:45 ` David Brownell
2008-09-24 10:44 ` Felipe Balbi
2008-09-24 11:25 ` Tony Lindgren
2008-09-24 15:34 ` David Brownell
2008-09-24 22:44 ` Felipe Balbi
2008-09-24 23:24 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809241624.30071.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=k.kooi@student.utwente.nl \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.