From: Wang Jian <lark@linux.net.cn>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] pata_platform struct resource signness fix
Date: Thu, 25 Sep 2008 16:36:46 +0800 [thread overview]
Message-ID: <20080925083622.GA2701@debian> (raw)
Hi,
This patch is to pata_platform.c but at this time, it's powerpc specific
because it can only be triggerred using openfirmware, so I post the patch
here. The patch is against 2.6.26-rc8.
The problem is triggerred when ata device is populated using
pata_of_platform.c, and no irq is assigned (poll mode, such as CF card).
pata_of_platform_probe() parse device tree and
if (ret == NO_IRQ)
irq_res.start = irq_res.end = -1;
Then irq is 0xffffffff, not NULL. Probe will fail coz irq can't be
requested.
---
(irq_res->start > 0) will be true even when it is (-1). When the device
has no irq, irq_res->start is assigned (-1).
Signed-off-by: Wang Jian <lark@linux.net.cn>
---
drivers/ata/pata_platform.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c
index 8f65ad6..b12cd0c 100644
--- a/drivers/ata/pata_platform.c
+++ b/drivers/ata/pata_platform.c
@@ -123,7 +123,7 @@ int __devinit __pata_platform_probe(struct device *dev,
/*
* And the IRQ
*/
- if (irq_res && irq_res->start > 0) {
+ if (irq_res && irq_res->start != -1) {
irq = irq_res->start;
irq_flags = irq_res->flags;
}
--
1.5.5.4
next reply other threads:[~2008-09-25 8:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 8:36 Wang Jian [this message]
2008-09-25 8:54 ` [PATCH] pata_platform struct resource signness fix Wang Jian
2008-09-25 10:40 ` Li Yang
2008-09-25 10:40 ` Li Yang
2008-09-25 10:48 ` Anton Vorontsov
2008-09-25 10:48 ` Anton Vorontsov
2008-09-29 4:19 ` Jeff Garzik
2008-09-29 4:19 ` Jeff Garzik
2008-09-29 13:32 ` [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-09-29 13:32 ` Anton Vorontsov
2008-09-25 15:33 ` [PATCH] pata_platform struct resource signness fix Wang Jian
2008-09-25 15:47 ` Anton Vorontsov
2008-09-25 15:47 ` Anton Vorontsov
2008-09-25 9:12 ` Leo Li
2008-09-25 9:30 ` Wang Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925083622.GA2701@debian \
--to=lark@linux.net.cn \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.