From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Wang Jian <lark@linux.net.cn>
Cc: Li Yang <leoli@freescale.com>,
linuxppc-dev@ozlabs.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_platform struct resource signness fix
Date: Thu, 25 Sep 2008 19:47:27 +0400 [thread overview]
Message-ID: <20080925154727.GA1620@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <48DBAF4F.3020003@linux.net.cn>
On Thu, Sep 25, 2008 at 11:33:35PM +0800, Wang Jian wrote:
> Li Yang wrote:
>> On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <lark@linux.net.cn> wrote:
>>> The alternative fix can be.
>>
>> This one is better as 0 is defined as 'invalid irq' for all
>> architectures. Added linux-ide and Anton to cc.
>
> However, this is not very true. Just git grep "#define NO_IRQ" and see. It
> seems that the NO_IRQ is in transition from (-1) to (0).
Yeah, there is a mess, but it gets better as time goes by.
The platforms/drivers should be fixed, since 0 is the only
invalid VIRQ.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Wang Jian <lark@linux.net.cn>
Cc: linuxppc-dev@ozlabs.org, Li Yang <leoli@freescale.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_platform struct resource signness fix
Date: Thu, 25 Sep 2008 19:47:27 +0400 [thread overview]
Message-ID: <20080925154727.GA1620@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <48DBAF4F.3020003@linux.net.cn>
On Thu, Sep 25, 2008 at 11:33:35PM +0800, Wang Jian wrote:
> Li Yang wrote:
>> On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <lark@linux.net.cn> wrote:
>>> The alternative fix can be.
>>
>> This one is better as 0 is defined as 'invalid irq' for all
>> architectures. Added linux-ide and Anton to cc.
>
> However, this is not very true. Just git grep "#define NO_IRQ" and see. It
> seems that the NO_IRQ is in transition from (-1) to (0).
Yeah, there is a mess, but it gets better as time goes by.
The platforms/drivers should be fixed, since 0 is the only
invalid VIRQ.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-09-25 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 8:36 [PATCH] pata_platform struct resource signness fix Wang Jian
2008-09-25 8:54 ` Wang Jian
2008-09-25 10:40 ` Li Yang
2008-09-25 10:40 ` Li Yang
2008-09-25 10:48 ` Anton Vorontsov
2008-09-25 10:48 ` Anton Vorontsov
2008-09-29 4:19 ` Jeff Garzik
2008-09-29 4:19 ` Jeff Garzik
2008-09-29 13:32 ` [PATCH] pata_of_platform: fix no irq handling Anton Vorontsov
2008-09-29 13:32 ` Anton Vorontsov
2008-09-25 15:33 ` [PATCH] pata_platform struct resource signness fix Wang Jian
2008-09-25 15:47 ` Anton Vorontsov [this message]
2008-09-25 15:47 ` Anton Vorontsov
2008-09-25 9:12 ` Leo Li
2008-09-25 9:30 ` Wang Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925154727.GA1620@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=lark@linux.net.cn \
--cc=leoli@freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.