All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Jeff Garzik <jgarzik@pobox.com>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: netdev@vger.kernel.org, linux-pci@vger.kernel.org,
	Ben Hutchings <bhutchings@solarflare.com>,
	Ivan Vecera <ivecera@redhat.com>
Subject: [PATCH 4/9] sky2: set VPD size
Date: Thu, 25 Sep 2008 09:48:55 -0700	[thread overview]
Message-ID: <20080925165223.451775520@vyatta.com> (raw)
In-Reply-To: 20080925164851.694359776@vyatta.com

[-- Attachment #1: sky2-vpd-size.patch --]
[-- Type: text/plain, Size: 2073 bytes --]

Read configuration register during probe and use it to size the
available VPD. Move existing code using same register slightly
earlier in probe handling.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/net/sky2.c	2008-09-09 13:56:09.000000000 -0700
+++ b/drivers/net/sky2.c	2008-09-09 13:57:07.000000000 -0700
@@ -4281,6 +4281,7 @@ static int __devinit sky2_probe(struct p
 	struct net_device *dev;
 	struct sky2_hw *hw;
 	int err, using_dac = 0, wol_default;
+	u32 reg;
 	char buf1[16];
 
 	err = pci_enable_device(pdev);
@@ -4314,6 +4315,34 @@ static int __devinit sky2_probe(struct p
 		}
 	}
 
+	/* Get configuration information
+	 * Note: only regular PCI config access once to test for HW issues
+	 *       other PCI access through shared memory for speed and to
+	 *	 avoid MMCONFIG problems.
+	 */
+	err = pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);
+	if (err) {
+		dev_err(&pdev->dev, "PCI read config failed\n");
+		goto err_out_free_regions;
+	}
+
+	/* size of available VPD, only impact sysfs */
+	err = pci_vpd_truncate(pdev, 1ul << (((reg & PCI_VPD_ROM_SZ) >> 14) + 8));
+	if (err)
+		dev_warn(&pdev->dev, "Can't set VPD size\n");
+
+#ifdef __BIG_ENDIAN
+	/* The sk98lin vendor driver uses hardware byte swapping but
+	 * this driver uses software swapping.
+	 */
+	reg &= ~PCI_REV_DESC;
+	err = pci_write_config_dword(pdev,PCI_DEV_REG2, reg);
+	if (err) {
+		dev_err(&pdev->dev, "PCI write config failed\n");
+		goto err_out_free_regions;
+	}
+#endif
+
 	wol_default = pci_wake_enabled(pdev) ? WAKE_MAGIC : 0;
 
 	err = -ENOMEM;
@@ -4331,18 +4360,6 @@ static int __devinit sky2_probe(struct p
 		goto err_out_free_hw;
 	}
 
-#ifdef __BIG_ENDIAN
-	/* The sk98lin vendor driver uses hardware byte swapping but
-	 * this driver uses software swapping.
-	 */
-	{
-		u32 reg;
-		reg = sky2_pci_read32(hw, PCI_DEV_REG2);
-		reg &= ~PCI_REV_DESC;
-		sky2_pci_write32(hw, PCI_DEV_REG2, reg);
-	}
-#endif
-
 	/* ring for status responses */
 	hw->st_le = pci_alloc_consistent(pdev, STATUS_LE_BYTES, &hw->st_dma);
 	if (!hw->st_le)

-- 


  parent reply	other threads:[~2008-09-25 16:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 16:48 [PATCH 0/9] PCI vpd patches (rev4) Stephen Hemminger
2008-09-25 16:48 ` [PATCH 1/9] PCI: vpd handle longer delays in access (rev3) Stephen Hemminger
2008-09-25 18:54   ` Matthew Wilcox
2008-09-25 16:48 ` [PATCH 2/9] PCI: revise VPD access interface (rev3) Stephen Hemminger
2008-09-25 17:58   ` Ben Hutchings
2008-09-25 16:48 ` [PATCH 3/9] PCI: add interface to set visible size of VPD (rev3) Stephen Hemminger
2008-09-25 17:22   ` Jeff Garzik
2008-09-25 17:49     ` Ben Hutchings
2008-09-25 16:48 ` Stephen Hemminger [this message]
2008-09-25 16:48 ` [PATCH 5/9] sky2: move VPD display into debug interface Stephen Hemminger
2008-09-25 16:48 ` [PATCH 6/9] sky2: remove VPD eeprom Stephen Hemminger
2008-09-25 16:48 ` [PATCH 7/9] skge: set VPD size Stephen Hemminger
2008-09-25 16:48 ` [PATCH 8/9] skge: add VPD display into debug interface Stephen Hemminger
2008-09-25 17:23   ` Jeff Garzik
2008-09-25 16:49 ` [PATCH 9/9] skge: remove VPD eeprom Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2008-10-13 20:13 [PATCH 0/9] Vital Product Data (VPD) patches relating to skge/sky2 Stephen Hemminger
2008-10-13 20:13 ` [PATCH 4/9] sky2: set VPD size Stephen Hemminger
2008-09-09 18:20 [PATCH 0/9] PCI VPD related patches Stephen Hemminger
2008-09-09 18:20 ` [PATCH 4/9] sky2: set VPD size Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080925165223.451775520@vyatta.com \
    --to=shemminger@vyatta.com \
    --cc=bhutchings@solarflare.com \
    --cc=ivecera@redhat.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.