From: Matthew Wilcox <matthew@wil.cx>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
Ben Hutchings <bhutchings@solarflare.com>,
Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH 1/9] PCI: vpd handle longer delays in access (rev3)
Date: Thu, 25 Sep 2008 12:54:26 -0600 [thread overview]
Message-ID: <20080925185426.GT27204@parisc-linux.org> (raw)
In-Reply-To: <20080925165223.168847327@vyatta.com>
On Thu, Sep 25, 2008 at 09:48:52AM -0700, Stephen Hemminger wrote:
> + if(!cond_resched())
Style nit (did you run checkpatch?)
I think I've commented on the previous versions of this patch enough for
it to be worth adding:
Reviwed-by: Matthew Wilcox <willy@linux.intel.com>
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-09-25 18:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 16:48 [PATCH 0/9] PCI vpd patches (rev4) Stephen Hemminger
2008-09-25 16:48 ` [PATCH 1/9] PCI: vpd handle longer delays in access (rev3) Stephen Hemminger
2008-09-25 18:54 ` Matthew Wilcox [this message]
2008-09-25 16:48 ` [PATCH 2/9] PCI: revise VPD access interface (rev3) Stephen Hemminger
2008-09-25 17:58 ` Ben Hutchings
2008-09-25 16:48 ` [PATCH 3/9] PCI: add interface to set visible size of VPD (rev3) Stephen Hemminger
2008-09-25 17:22 ` Jeff Garzik
2008-09-25 17:49 ` Ben Hutchings
2008-09-25 16:48 ` [PATCH 4/9] sky2: set VPD size Stephen Hemminger
2008-09-25 16:48 ` [PATCH 5/9] sky2: move VPD display into debug interface Stephen Hemminger
2008-09-25 16:48 ` [PATCH 6/9] sky2: remove VPD eeprom Stephen Hemminger
2008-09-25 16:48 ` [PATCH 7/9] skge: set VPD size Stephen Hemminger
2008-09-25 16:48 ` [PATCH 8/9] skge: add VPD display into debug interface Stephen Hemminger
2008-09-25 17:23 ` Jeff Garzik
2008-09-25 16:49 ` [PATCH 9/9] skge: remove VPD eeprom Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2008-09-09 18:20 [PATCH 0/9] PCI VPD related patches Stephen Hemminger
2008-09-09 18:20 ` [PATCH 1/9] PCI: vpd handle longer delays in access (rev3) Stephen Hemminger
2008-09-09 20:23 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925185426.GT27204@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bhutchings@solarflare.com \
--cc=ivecera@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jgarzik@pobox.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.