* [PATCH] alsa-plugins: Fix destruction order on failure
@ 2008-09-25 19:02 Lennart Poettering
0 siblings, 0 replies; only message in thread
From: Lennart Poettering @ 2008-09-25 19:02 UTC (permalink / raw)
To: ALSA Development Mailing List
Heya!
If we failure we should make sure the event loop thread is not running
and hence not accessing our source/sink strings before we free those
strings.
---
pulse/ctl_pulse.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/pulse/ctl_pulse.c b/pulse/ctl_pulse.c
index 0b10628..8a5546c 100644
--- a/pulse/ctl_pulse.c
+++ b/pulse/ctl_pulse.c
@@ -728,14 +728,11 @@ SND_CTL_PLUGIN_DEFINE_FUNC(pulse)
return 0;
error:
- if (ctl->source)
- free(ctl->source);
- if (ctl->sink)
- free(ctl->sink);
-
if (ctl->p)
pulse_free(ctl->p);
+ free(ctl->source);
+ free(ctl->sink);
free(ctl);
return err;
--
1.6.0.1
Lennart
--
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net ICQ# 11060553
http://0pointer.net/lennart/ GnuPG 0x1A015CC4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-09-25 19:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-25 19:02 [PATCH] alsa-plugins: Fix destruction order on failure Lennart Poettering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.