From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Mikko Ylinen <mikko.k.ylinen@nokia.com>,
Steve Sakoman <sakoman@gmail.com>
Subject: Re: [PATCH 9/9] i2c: move twl4030-madc to new registration style
Date: Fri, 26 Sep 2008 12:50:50 -0700 [thread overview]
Message-ID: <200809261250.50893.david-b@pacbell.net> (raw)
In-Reply-To: <1222427996-7018-10-git-send-email-felipe.balbi@nokia.com>
On Friday 26 September 2008, Felipe Balbi wrote:
> arch/arm/mach-omap2/board-omap3beagle.c | 6 +
> arch/arm/mach-omap2/board-overo.c | 6 +
For the record: this reverts those two little evil additions;
build fix, and correctness update for at least Beagle.
Steve, if Overo wires out any of the ADC channels on that
one connector, you may want to come up with a better fox.
- Dave
====== SNIP!
--- beagle.orig/arch/arm/mach-omap2/board-omap3beagle.c 2008-09-26 12:47:36.000000000 -0700
+++ beagle/arch/arm/mach-omap2/board-omap3beagle.c 2008-09-26 09:55:50.000000000 -0700
@@ -114,11 +114,6 @@ static struct twl4030_usb_data beagle_us
.usb_mode = T2_USB_MODE_ULPI,
};
-static struct twl4030_madc_platform_data beagle_madc_data = {
- .imr = TWL4030_MADC_IMR1,
- .isr = TWL4030_MADC_ISR1,
-};
-
static struct twl4030_gpio_platform_data beagle_gpio_data = {
.gpio_base = OMAP_MAX_GPIO_LINES,
.irq_base = TWL4030_GPIO_IRQ_BASE,
@@ -135,7 +130,6 @@ static struct twl4030_platform_data beag
.irq_end = TWL4030_IRQ_END,
/* platform_data for children goes here */
- .madc = &beagle_madc_data,
.usb = &beagle_usb_data,
.gpio = &beagle_gpio_data,
};
--- beagle.orig/arch/arm/mach-omap2/board-overo.c 2008-09-26 12:47:36.000000000 -0700
+++ beagle/arch/arm/mach-omap2/board-overo.c 2008-09-26 10:02:29.000000000 -0700
@@ -152,16 +152,10 @@ static struct twl4030_gpio_platform_data
.irq_end = TWL4030_GPIO_IRQ_END,
};
-static struct twl4030_madc_platform_data overo_madc_data = {
- .imr = TWL4030_MADC_IMR1,
- .isr = TWL4030_MADC_ISR1,
-};
-
static struct twl4030_platform_data overo_twldata = {
.irq_base = TWL4030_IRQ_BASE,
.irq_end = TWL4030_IRQ_END,
.gpio = &overo_gpio_data,
- .madc = &overo_madc_data,
};
static struct i2c_board_info __initdata overo_i2c_boardinfo[] = {
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-09-26 19:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 11:19 [PATCH 0/9] twl4030 updates Felipe Balbi
2008-09-26 11:19 ` [PATCH 1/9] twl4030: fix potential null pointer dereference Felipe Balbi
2008-09-26 11:19 ` [PATCH 2/9] twl4030-gpio: Remove default pullup enable/disable of GPIO Felipe Balbi
2008-09-26 11:19 ` [PATCH 3/9] i2c: clean add_children a bit Felipe Balbi
2008-09-26 11:19 ` [PATCH 4/9] i2c: move twl4030_keypad to new style registration Felipe Balbi
2008-09-26 11:19 ` [PATCH 5/9] i2c: move twl4030-usb to platform_device Felipe Balbi
2008-09-26 11:19 ` [PATCH 6/9] i2c: twl4030-usb: add 'vbus' sysfs file Felipe Balbi
2008-09-26 11:19 ` [PATCH 7/9] twl4030 gpio platform data Felipe Balbi
2008-09-26 11:19 ` [PATCH 8/9] twl4030 uses gpiolib Felipe Balbi
2008-09-26 11:19 ` [PATCH 9/9] i2c: move twl4030-madc to new registration style Felipe Balbi
2008-09-26 17:09 ` David Brownell
2008-09-26 17:46 ` Felipe Balbi
2008-09-27 7:37 ` Mikko Ylinen
2008-09-27 15:04 ` David Brownell
2008-09-27 15:40 ` Steve Sakoman
2008-09-27 17:17 ` David Brownell
2008-10-01 14:20 ` Mikko Ylinen
2008-10-01 16:13 ` David Brownell
2008-09-26 19:50 ` David Brownell [this message]
2008-09-26 20:01 ` Steve Sakoman
2008-09-26 17:10 ` [PATCH 8/9] twl4030 uses gpiolib David Brownell
2008-09-26 17:47 ` Felipe Balbi
2008-09-26 18:57 ` David Brownell
2008-09-28 1:01 ` [PATCH 5/9] i2c: move twl4030-usb to platform_device David Brownell
2008-09-28 3:03 ` Felipe Balbi
2008-09-26 17:12 ` [PATCH 0/9] twl4030 updates David Brownell
2008-09-26 17:50 ` Felipe Balbi
2008-09-26 18:55 ` David Brownell
2008-09-26 19:00 ` David Brownell
2008-09-26 19:10 ` Steve Sakoman
2008-09-26 19:23 ` Felipe Balbi
2008-09-26 19:45 ` David Brownell
2008-09-27 19:14 ` David Brownell
2008-09-27 21:17 ` Felipe Balbi
2008-09-27 21:45 ` David Brownell
2008-09-27 21:46 ` Felipe Balbi
2008-09-27 21:41 ` [PATCH 11/9] move twl4030-gpio to drivers/gpio David Brownell
2008-09-27 22:29 ` Felipe Balbi
2008-09-27 23:09 ` Felipe Balbi
2008-09-27 23:45 ` David Brownell
2008-09-28 3:14 ` Felipe Balbi
2008-09-28 5:16 ` David Brownell
2008-10-01 13:46 ` Felipe Contreras
2008-10-01 13:52 ` Felipe Balbi
2008-10-01 15:58 ` David Brownell
2008-10-01 16:05 ` Jean Delvare
2008-10-01 16:32 ` David Brownell
2008-09-27 23:29 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809261250.50893.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=mikko.k.ylinen@nokia.com \
--cc=sakoman@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.