From: David Brownell <david-b@pacbell.net>
To: me@felipebalbi.com
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH 11/9] move twl4030-gpio to drivers/gpio
Date: Sat, 27 Sep 2008 16:29:33 -0700 [thread overview]
Message-ID: <200809271629.34462.david-b@pacbell.net> (raw)
In-Reply-To: <20080927222900.GC8468@frodo>
On Saturday 27 September 2008, Felipe Balbi wrote:
> This patch breaks hsmmc.c:
> arch/arm/mach-omap2/built-in.o: In function `hsmmc_card_detect':
> /home/underline/workspace/linux-omap-2.6/arch/arm/mach-omap2/hsmmc.c:51: undefined reference to `twl4030_get_gpio_datain'
> ... etc
Could you verify that still happens with a build-from-scratch?
Like, one in which you made sure to enable CONFIG_GPIO_TWL4030?
I certainly don't get those errors. That's exactly why those
few TWL-specific symbols are left in that driver: because that
file still uses them. They get removed later, before this gets
sent upstream.
- Dave
prev parent reply other threads:[~2008-09-27 23:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 11:19 [PATCH 0/9] twl4030 updates Felipe Balbi
2008-09-26 11:19 ` [PATCH 1/9] twl4030: fix potential null pointer dereference Felipe Balbi
2008-09-26 11:19 ` [PATCH 2/9] twl4030-gpio: Remove default pullup enable/disable of GPIO Felipe Balbi
2008-09-26 11:19 ` [PATCH 3/9] i2c: clean add_children a bit Felipe Balbi
2008-09-26 11:19 ` [PATCH 4/9] i2c: move twl4030_keypad to new style registration Felipe Balbi
2008-09-26 11:19 ` [PATCH 5/9] i2c: move twl4030-usb to platform_device Felipe Balbi
2008-09-26 11:19 ` [PATCH 6/9] i2c: twl4030-usb: add 'vbus' sysfs file Felipe Balbi
2008-09-26 11:19 ` [PATCH 7/9] twl4030 gpio platform data Felipe Balbi
2008-09-26 11:19 ` [PATCH 8/9] twl4030 uses gpiolib Felipe Balbi
2008-09-26 11:19 ` [PATCH 9/9] i2c: move twl4030-madc to new registration style Felipe Balbi
2008-09-26 17:09 ` David Brownell
2008-09-26 17:46 ` Felipe Balbi
2008-09-27 7:37 ` Mikko Ylinen
2008-09-27 15:04 ` David Brownell
2008-09-27 15:40 ` Steve Sakoman
2008-09-27 17:17 ` David Brownell
2008-10-01 14:20 ` Mikko Ylinen
2008-10-01 16:13 ` David Brownell
2008-09-26 19:50 ` David Brownell
2008-09-26 20:01 ` Steve Sakoman
2008-09-26 17:10 ` [PATCH 8/9] twl4030 uses gpiolib David Brownell
2008-09-26 17:47 ` Felipe Balbi
2008-09-26 18:57 ` David Brownell
2008-09-28 1:01 ` [PATCH 5/9] i2c: move twl4030-usb to platform_device David Brownell
2008-09-28 3:03 ` Felipe Balbi
2008-09-26 17:12 ` [PATCH 0/9] twl4030 updates David Brownell
2008-09-26 17:50 ` Felipe Balbi
2008-09-26 18:55 ` David Brownell
2008-09-26 19:00 ` David Brownell
2008-09-26 19:10 ` Steve Sakoman
2008-09-26 19:23 ` Felipe Balbi
2008-09-26 19:45 ` David Brownell
2008-09-27 19:14 ` David Brownell
2008-09-27 21:17 ` Felipe Balbi
2008-09-27 21:45 ` David Brownell
2008-09-27 21:46 ` Felipe Balbi
2008-09-27 21:41 ` [PATCH 11/9] move twl4030-gpio to drivers/gpio David Brownell
2008-09-27 22:29 ` Felipe Balbi
2008-09-27 23:09 ` Felipe Balbi
2008-09-27 23:45 ` David Brownell
2008-09-28 3:14 ` Felipe Balbi
2008-09-28 5:16 ` David Brownell
2008-10-01 13:46 ` Felipe Contreras
2008-10-01 13:52 ` Felipe Balbi
2008-10-01 15:58 ` David Brownell
2008-10-01 16:05 ` Jean Delvare
2008-10-01 16:32 ` David Brownell
2008-09-27 23:29 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809271629.34462.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=khali@linux-fr.org \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.