Re: [PATCH 3/5] [RFC] ALSA ASOC Adds DSP DAI format support for platform driver

[Jarkko Nikula <jarkko.nikula@nokia.com>]

On Mon, 29 Sep 2008 15:20:12 +0530
"ext Arun KS" <arunks@mistralsolutions.com> wrote:

> Enables DSP DAI format for mcbsp in omap platform driver
> 
> Signed-off-by: Arun KS <arunks@mistralsolutions.com>
> ---
>  sound/soc/omap/omap-mcbsp.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index 3a4cc4b..1c024aa 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -292,6 +292,12 @@ static int omap_mcbsp_dai_set_dai_fmt(struct
> snd_soc_dai *cpu_dai,
>  		regs->rcr2	|= RDATDLY(1);
>  		regs->xcr2	|= XDATDLY(1);
>  		break;
> +	case SND_SOC_DAIFMT_DSP_A:
> +		/* 0-bit data delay */
> +		regs->rcr2	|= RDATDLY(0);
> +		regs->xcr2	|= XDATDLY(0);
> +		break;
> +
>  	default:

I think this is not enough. The word clock length equals to one BCLK
cycle in DSP mode. Not n channel bit BCLK cycles like in I2S.


Jarkko