Re: [PATCH] Warning if grub.cfg not found

[Robert Millan <rmh@aybabtu.com>]

On Sun, Sep 28, 2008 at 11:41:02PM +0200, Carles Pina i Estany wrote:
> 
> Hello,
> 
> On Sep/28/2008, Robert Millan wrote:
> > On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote:
> > > --- normal/main.c	(revision 1877)
> > > +++ normal/main.c	(working copy)
> > > @@ -230,7 +230,13 @@
> > >    /* Try to open the config file.  */
> > >    file = grub_file_open (config);
> > >    if (! file)
> > > -    return 0;
> > > +    {
> > 
> > This seems to include the possibility that file cannot be read simply because
> > it's not there.  Perhaps user intended so, and this shouldn't be reported as
> > an error.
> 
> Do you mean that we could change:
> +      grub_print_error ();
> 
> by "grub_print_warning"?
> 
> Or the whole point (warn the user if file is not there) is incorrect?
> 
> If user doesn't want a grub.cfg, he/she could "touch grub.cfg" and
> that's all, no?
> 
> If some user is miss-configuring Grub2 (pointing to an invalid device,
> partition, etc.) he will prefer to read "cannot find grub.cfg" than just
> see a shell (it's quite confusing, or it was for me when it happened :-)
> )

I think it's fine to tell the user about it, but without impliing that it
is an error.  E.g. something like "grub.cfg not found, falling back to xxx",
without waiting for user confirmation.

What does everyone else think about this?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."