From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Warning if grub.cfg not found
Date: Sun, 28 Sep 2008 15:26:26 +0200 [thread overview]
Message-ID: <20080928132626.GA23805@thorin> (raw)
In-Reply-To: <20080927173752.GA23044@pina.cat>
On Sat, Sep 27, 2008 at 07:37:52PM +0200, Carles Pina i Estany wrote:
> --- normal/main.c (revision 1877)
> +++ normal/main.c (working copy)
> @@ -230,7 +230,13 @@
> /* Try to open the config file. */
> file = grub_file_open (config);
> if (! file)
> - return 0;
> + {
This seems to include the possibility that file cannot be read simply because
it's not there. Perhaps user intended so, and this shouldn't be reported as
an error.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2008-09-28 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 14:43 [PATCH] Warning if grub.cfg not found Carles Pina i Estany
2008-08-23 14:48 ` Carles Pina i Estany
2008-08-30 11:43 ` Robert Millan
2008-09-05 16:59 ` Carles Pina i Estany
2008-09-27 17:37 ` Carles Pina i Estany
2008-09-28 13:26 ` Robert Millan [this message]
2008-09-28 21:41 ` Carles Pina i Estany
2008-09-29 14:54 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080928132626.GA23805@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.