Re: [PATCH 6/9] x86/iommu: change Calgary to use dma_ops register interface

[Muli Ben-Yehuda <muli@il.ibm.com>]

On Tue, Sep 30, 2008 at 05:38:15PM +0200, Ingo Molnar wrote:
> 
> * Muli Ben-Yehuda <muli@il.ibm.com> wrote:
> 
> > > > +static int calgary_device_supported(struct device *dev)
> > > > +{
> > > > +	return translation_enabled(find_iommu_table(dev));
> > > > +}
> > 
> > Sure, but I prefer the explicit form since it lends itself to easier
> > debugging (oops line numbers, adding printks, etc.).
> 
> we never do that for simple stuff like this. The kernel would be
> twice as large if we did.

I assume you are talking about the source size, because the generated
code size should be exactly the same.

In any case, arguing where to place the semi-colon is a waste of
time. Do as you see fit.

Cheers,
Muli
-- 
The First Workshop on I/O Virtualization (WIOV '08)
Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/
                      xxx
SYSTOR 2009---The Israeli Experimental Systems Conference
http://www.haifa.il.ibm.com/conferences/systor2009/