All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [GUILT] Use git_editor
Date: Tue, 30 Sep 2008 15:07:44 -0400	[thread overview]
Message-ID: <20080930190744.GO32444@josefsipek.net> (raw)
In-Reply-To: <48E27366.3080503@tuffmail.co.uk>

On Tue, Sep 30, 2008 at 07:43:50PM +0100, Alan Jenkins wrote:
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
> 
> diff --git a/guilt b/guilt
> index 1cef7b9..8d023e9 100755
> --- a/guilt
> +++ b/guilt
> @@ -693,10 +693,6 @@ fi
>  series="$GUILT_DIR/$branch/series"
>  applied="$GUILT_DIR/$branch/status"
>  
> -# determine an editor to use for anything interactive (fall back to vi)
> -editor="vi"
> -[ ! -z "$EDITOR" ] && editor="$EDITOR"
> -

Looks good from a quick glance. Any chance there's a git_pager?

Josef 'Jeff' Sipek.

-- 
Bad pun of the week: The formula 1 control computer suffered from a race
condition

  reply	other threads:[~2008-09-30 19:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30 18:43 [GUILT] Use git_editor Alan Jenkins
2008-09-30 19:07 ` Josef 'Jeff' Sipek [this message]
2008-09-30 19:14   ` Alan Jenkins
2008-09-30 20:22     ` Josef 'Jeff' Sipek
2008-10-01  2:31 ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930190744.GO32444@josefsipek.net \
    --to=jeffpc@josefsipek.net \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.