From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
Cc: git@vger.kernel.org
Subject: [GUILT] Use git_editor
Date: Tue, 30 Sep 2008 19:43:50 +0100 [thread overview]
Message-ID: <48E27366.3080503@tuffmail.co.uk> (raw)
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
diff --git a/guilt b/guilt
index 1cef7b9..8d023e9 100755
--- a/guilt
+++ b/guilt
@@ -693,10 +693,6 @@ fi
series="$GUILT_DIR/$branch/series"
applied="$GUILT_DIR/$branch/status"
-# determine an editor to use for anything interactive (fall back to vi)
-editor="vi"
-[ ! -z "$EDITOR" ] && editor="$EDITOR"
-
# determine a pager to use for anything interactive (fall back to more)
pager="more"
[ ! -z "$PAGER" ] && pager="$PAGER"
diff --git a/guilt-header b/guilt-header
index da46c82..66521ac 100755
--- a/guilt-header
+++ b/guilt-header
@@ -46,7 +46,7 @@ if [ -z "$edit" ]; then
else
do_get_full_header "$GUILT_DIR/$branch/$patch" > "$TMP_MSG"
do_get_patch "$GUILT_DIR/$branch/$patch" > "$TMP_DIFF"
- $editor "$TMP_MSG"
+ git_editor "$TMP_MSG"
mv "$GUILT_DIR/$branch/$patch" "$GUILT_DIR/$branch/$patch~"
(
diff --git a/guilt-new b/guilt-new
index 05318a5..7845d00 100755
--- a/guilt-new
+++ b/guilt-new
@@ -77,7 +77,7 @@ mkdir_dir=`dirname "$GUILT_DIR/$branch/$patch"`
) >> "$GUILT_DIR/$branch/$patch"
# edit -e ?
-[ "$edit" = "t" ] && $editor "$GUILT_DIR/$branch/$patch"
+[ "$edit" = "t" ] && git_editor "$GUILT_DIR/$branch/$patch"
if [ ! -z "$force" ]; then
(
diff --git a/guilt-series b/guilt-series
index 7d8f8e9..4f24ffd 100755
--- a/guilt-series
+++ b/guilt-series
@@ -22,7 +22,7 @@ do
done
if [ ! -z "$edit" ]; then
- $editor "$series"
+ git_editor "$series"
elif [ ! -z "$gui" ]; then
[ -z "`get_top`" ] && die "No patches applied."
bottom=`git rev-parse refs/patches/$branch/$(head -1 $applied)`
next reply other threads:[~2008-09-30 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 18:43 Alan Jenkins [this message]
2008-09-30 19:07 ` [GUILT] Use git_editor Josef 'Jeff' Sipek
2008-09-30 19:14 ` Alan Jenkins
2008-09-30 20:22 ` Josef 'Jeff' Sipek
2008-10-01 2:31 ` Josef 'Jeff' Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E27366.3080503@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=git@vger.kernel.org \
--cc=jeffpc@josefsipek.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.