RFC: Making it mandantory to have a checksums.ini entry

* RFC: Making it mandantory to have a checksums.ini entry
@ 2008-10-01  2:47 Holger Freyther
  2008-10-01  2:58 ` Otavio Salvador
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Holger Freyther @ 2008-10-01  2:47 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hey,

I constantly spend my day moving checksums from tmp/checksums.ini to the right 
place and I would like to make it mandatory to have a checksums.ini entry 
when adding new versions.

The spend time on copy and pasting a checksums.ini entry is really small and 
the value is very high. Stuff like macports is forcing one to have checksums 
as well.

The attached diff would force it.

comments appreciated
	z.

[-- Attachment #2: make-it-mandantory.diff --]
[-- Type: text/x-diff, Size: 801 bytes --]

diff --git a/classes/base.bbclass b/classes/base.bbclass
index 2025483..a2a93c8 100644
--- a/classes/base.bbclass
+++ b/classes/base.bbclass
@@ -602,7 +602,10 @@ python base_do_fetch() {
 		try:
 			if type == "http" or type == "https" or type == "ftp" or type == "ftps":
 				if not base_chk_file(parser, pn, pv,uri, localpath, d):
-					bb.note("%s-%s: %s has no entry in conf/checksums.ini, not checking URI" % (pn,pv,uri))
+					if not bb.data.getVar("OE_ALLOW_INSECURE_DOWNLOADS",d, True):
+						bb.fatal("%s-%s: %s has no entry in conf/checksums.ini, not checking URI" % (pn,pv,uri))
+					else:
+						bb.note("%s-%s: %s has no entry in conf/checksums.ini, not checking URI" % (pn,pv,uri))
 		except Exception:
 			raise bb.build.FuncFailed("Checksum of '%s' failed" % uri)
 }

^ permalink raw reply related	[flat|nested] 11+ messages in thread