All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
	Tony Lindgren <tony@atomide.com>,
	Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH 1/3] [RFC] clk: introduce clk_associate
Date: Wed, 1 Oct 2008 08:51:46 -0700	[thread overview]
Message-ID: <200810010851.47774.david-b@pacbell.net> (raw)
In-Reply-To: <1222857363-25055-2-git-send-email-felipe.balbi@nokia.com>

On Wednesday 01 October 2008, Felipe Balbi wrote:
> +/**
> + * clk_associate - associates a user to a clock so device drivers don't
> + * have to care about clock names
> + *
> + * @id: clock id as defined in arch/arm/mach-omapX/clkxxxx.h
> + * @dev: device pointer for the clock user
> + * @f: a function for the clock (uart_[if]ck, musb_ick, ehci_[if]ck, etc)
> + */
> +void __init clk_associate(const char *id, struct device *dev, const char *f)

Heh.  I remember coming up with that same abstraction
for mach-at91/clock.c a few years back.  It seems to
have worked fairly well in that far simpler environment,
and I can't imagine why it wouldn't work here too.

The name might be confusing though, since it's not part
of the standard clk_*() interface ... and the name might
be needed there, eventually.

So mirroring "at91_clock_associate()" ... maybe this
should be "omap_clock_associate()" not "clk_associate()".

- Dave

  parent reply	other threads:[~2008-10-01 15:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 10:36 [PATCH 0/3] [RFC] introduce clk_associate Felipe Balbi
2008-10-01 10:36 ` [PATCH 1/3] [RFC] clk: " Felipe Balbi
2008-10-01 10:36   ` [PATCH 2/3] [RFC] clk: use clk_associate for musb driver Felipe Balbi
2008-10-01 10:36     ` [PATCH 3/3] [RFC] clk: use clk_associate on watchdog driver Felipe Balbi
2008-10-01 15:51   ` David Brownell [this message]
2008-10-01 15:57     ` [PATCH 1/3] [RFC] clk: introduce clk_associate Felipe Balbi
2008-10-01 16:15       ` David Brownell
2008-10-01 18:34         ` Hiroshi DOYU
2008-10-02 20:50           ` David Brownell
2008-10-02 21:33             ` Felipe Balbi
2008-10-03  6:23             ` Hiroshi DOYU
2008-10-03  7:30               ` Tony Lindgren
2008-10-06 18:42               ` David Brownell
2008-10-06 18:53                 ` Felipe Balbi
2008-10-14 16:33           ` Paul Walmsley
2008-10-14 20:19             ` Hiroshi DOYU
2008-10-15  9:13               ` Paul Walmsley
2008-10-15 10:15                 ` Hiroshi DOYU
2008-10-15 22:41             ` Woodruff, Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810010851.47774.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=felipe.balbi@nokia.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.