All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: felipe.balbi@nokia.com, linux-omap@vger.kernel.org,
	paul@pwsan.com, tony@atomide.com, khilman@deeprootsystems.com
Subject: Re: [PATCH 1/3] [RFC] clk: introduce clk_associate
Date: Mon, 6 Oct 2008 11:42:08 -0700	[thread overview]
Message-ID: <200810061142.08759.david-b@pacbell.net> (raw)
In-Reply-To: <20081003.092336.243854668.Hiroshi.DOYU@nokia.com>

On Thursday 02 October 2008, Hiroshi DOYU wrote:
> For some of the above drivers, omap's "functional clock" and
> "interface clock" doesn't make sense. 

Actually, I thought OMAP was pretty consistent about having
both on all modules where it made sense.


> For such device drivers, those 
> clocks may look just a single necessary clock and there's no "one to
> one" correspondence from the omap clock functionality definitions
> ("ick"/"fck") perspective.

They're all OMAP-specific drivers.  They can know that they
need to ask for both clocks.  If perchance only one of them
were actually needed, that would be exceptional ... and the
driver should be able to assume the device was properly
set up, and continue without it.


> I think that this is one of the examples, 
> where the flexibily is required. Since required functionaliies for
> clocks depends on each device drivers, I think that it would give a
> wider solution to let device drivers to define their logical
> clocks(functionality) flexibly(not 1-to-1), rather than statically
> pre-defined standardized functional names, which is the 1-to-1
> correspondence of ick and fck in the TRM with aliasing.

The ICK/FCK example is not IMO persuasive; this is OMAP, so
the assumption can be that all drivers have both.

Having the clocks set up by clk_associate() would suffice
for most devices and drivers.  Are there ones where that's
not enough ... where a device needs more than those "logical"
clock identifiers?

- Dave


  parent reply	other threads:[~2008-10-06 18:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 10:36 [PATCH 0/3] [RFC] introduce clk_associate Felipe Balbi
2008-10-01 10:36 ` [PATCH 1/3] [RFC] clk: " Felipe Balbi
2008-10-01 10:36   ` [PATCH 2/3] [RFC] clk: use clk_associate for musb driver Felipe Balbi
2008-10-01 10:36     ` [PATCH 3/3] [RFC] clk: use clk_associate on watchdog driver Felipe Balbi
2008-10-01 15:51   ` [PATCH 1/3] [RFC] clk: introduce clk_associate David Brownell
2008-10-01 15:57     ` Felipe Balbi
2008-10-01 16:15       ` David Brownell
2008-10-01 18:34         ` Hiroshi DOYU
2008-10-02 20:50           ` David Brownell
2008-10-02 21:33             ` Felipe Balbi
2008-10-03  6:23             ` Hiroshi DOYU
2008-10-03  7:30               ` Tony Lindgren
2008-10-06 18:42               ` David Brownell [this message]
2008-10-06 18:53                 ` Felipe Balbi
2008-10-14 16:33           ` Paul Walmsley
2008-10-14 20:19             ` Hiroshi DOYU
2008-10-15  9:13               ` Paul Walmsley
2008-10-15 10:15                 ` Hiroshi DOYU
2008-10-15 22:41             ` Woodruff, Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810061142.08759.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=felipe.balbi@nokia.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.