From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Steven Noonan <steven@uplinklabs.net>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -tip] drivers/serial/8250.c: 'i' may be used uninitialized
Date: Wed, 1 Oct 2008 12:57:41 +0200 [thread overview]
Message-ID: <20081001105741.GA32062@elte.hu> (raw)
In-Reply-To: <20081001113343.4bf25ea5@lxorguk.ukuu.org.uk>
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Wed, 1 Oct 2008 10:01:50 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > ( Alan Cc:-ed. Seems like gcc bogosity - so your solution of using
> > uninitialized_var() is the correct way to annotate this. )
>
> Sorry but uninitialized_var() is too ugly to be acceptable. Please use
> a proper __foo style notation for consistency with the rest of the
> kernel
it cannot be wrapped like that via __foo style notation (which can be
used for section tricks), and uninitialized_var() is the accepted
upstream facility for this, it got introduced 1.5 years ago, via commit
94909914 ("Add unitialized_var() macro for suppressing gcc warnings").
> (Besides which last time I checked current gcc could figure that one
> out)
that would indeed moot the patch.
Ingo
next prev parent reply other threads:[~2008-10-01 10:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 7:57 [PATCH -tip] pcm_native: label out defined but not used Steven Noonan
2008-10-01 7:57 ` [PATCH -tip] sdhci: 'scratch' may be used uninitialized Steven Noonan
2008-10-01 7:57 ` [PATCH -tip] drivers/serial/8250.c: 'i' " Steven Noonan
2008-10-01 8:01 ` Ingo Molnar
2008-10-01 8:16 ` Steven Noonan
2008-10-01 8:29 ` Ingo Molnar
2008-10-01 8:36 ` Steven Noonan
2008-10-01 8:47 ` [PATCH] " Steven Noonan
2008-10-01 21:36 ` Alan Cox
2008-10-02 9:02 ` Ingo Molnar
2008-10-01 8:48 ` [PATCH -tip] " Ingo Molnar
2008-10-01 10:34 ` Alan Cox
2008-10-01 10:33 ` Alan Cox
2008-10-01 10:57 ` Ingo Molnar [this message]
2008-10-01 15:41 ` Alan Cox
2008-10-02 9:00 ` Ingo Molnar
2008-10-01 8:00 ` [PATCH -tip] sdhci: 'scratch' " Ingo Molnar
2008-10-01 8:14 ` Steven Noonan
2008-10-01 8:33 ` Steven Noonan
2008-10-01 8:35 ` Ingo Molnar
2008-10-01 8:50 ` [PATCH] " Steven Noonan
2008-10-04 19:57 ` Pierre Ossman
2008-10-05 14:28 ` Adrian Bunk
2008-10-05 22:53 ` Steven Noonan
2008-10-05 23:16 ` Adrian Bunk
2008-10-05 23:48 ` Steven Noonan
2008-10-06 5:59 ` Adrian Bunk
2008-10-06 6:30 ` Ingo Molnar
2008-10-06 7:27 ` Pierre Ossman
2008-10-06 8:25 ` Ingo Molnar
2008-10-01 7:59 ` [PATCH -tip] pcm_native: label out defined but not used Ingo Molnar
2008-10-01 8:12 ` Steven Noonan
2008-10-01 8:13 ` Takashi Iwai
2008-10-01 8:32 ` Ingo Molnar
2008-10-01 8:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001105741.GA32062@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.