All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Noonan <steven@uplinklabs.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip] pcm_native: label out defined but not used
Date: Wed, 01 Oct 2008 10:13:47 +0200	[thread overview]
Message-ID: <s5h63ocd96s.wl%tiwai@suse.de> (raw)
In-Reply-To: <20081001075921.GA25832@elte.hu>

At Wed, 1 Oct 2008 09:59:21 +0200,
Ingo Molnar wrote:
> 
> 
> (Cc:-ed Taskashi for this ALSA cleanup patch.)

This label is used when the debug option is enabled.
So, don't apply this.

thanks,

Takashi

> * Steven Noonan <steven@uplinklabs.net> wrote:
> 
> > Signed-off-by: Steven Noonan <steven@uplinklabs.net>
> > ---
> >  sound/core/pcm_native.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> > index c487025..3953bf6 100644
> > --- a/sound/core/pcm_native.c
> > +++ b/sound/core/pcm_native.c
> > @@ -3252,7 +3252,7 @@ static int snd_pcm_fasync(int fd, struct file * file, int on)
> >  	runtime = substream->runtime;
> >  
> >  	err = fasync_helper(fd, file, on, &runtime->fasync);
> > -out:
> > +
> >  	unlock_kernel();
> >  	if (err < 0)
> >  		return err;
> > -- 
> > 1.6.0.2
> 

  parent reply	other threads:[~2008-10-01  8:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01  7:57 [PATCH -tip] pcm_native: label out defined but not used Steven Noonan
2008-10-01  7:57 ` [PATCH -tip] sdhci: 'scratch' may be used uninitialized Steven Noonan
2008-10-01  7:57   ` [PATCH -tip] drivers/serial/8250.c: 'i' " Steven Noonan
2008-10-01  8:01     ` Ingo Molnar
2008-10-01  8:16       ` Steven Noonan
2008-10-01  8:29         ` Ingo Molnar
2008-10-01  8:36           ` Steven Noonan
2008-10-01  8:47             ` [PATCH] " Steven Noonan
2008-10-01 21:36               ` Alan Cox
2008-10-02  9:02                 ` Ingo Molnar
2008-10-01  8:48             ` [PATCH -tip] " Ingo Molnar
2008-10-01 10:34         ` Alan Cox
2008-10-01 10:33       ` Alan Cox
2008-10-01 10:57         ` Ingo Molnar
2008-10-01 15:41           ` Alan Cox
2008-10-02  9:00             ` Ingo Molnar
2008-10-01  8:00   ` [PATCH -tip] sdhci: 'scratch' " Ingo Molnar
2008-10-01  8:14     ` Steven Noonan
2008-10-01  8:33       ` Steven Noonan
2008-10-01  8:35         ` Ingo Molnar
2008-10-01  8:50           ` [PATCH] " Steven Noonan
2008-10-04 19:57             ` Pierre Ossman
2008-10-05 14:28             ` Adrian Bunk
2008-10-05 22:53               ` Steven Noonan
2008-10-05 23:16                 ` Adrian Bunk
2008-10-05 23:48                   ` Steven Noonan
2008-10-06  5:59                     ` Adrian Bunk
2008-10-06  6:30                     ` Ingo Molnar
2008-10-06  7:27                       ` Pierre Ossman
2008-10-06  8:25                         ` Ingo Molnar
2008-10-01  7:59 ` [PATCH -tip] pcm_native: label out defined but not used Ingo Molnar
2008-10-01  8:12   ` Steven Noonan
2008-10-01  8:13   ` Takashi Iwai [this message]
2008-10-01  8:32     ` Ingo Molnar
2008-10-01  8:56       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h63ocd96s.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=steven@uplinklabs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.