From: David Brownell <david-b@pacbell.net>
To: alsa-devel@alsa-project.org
Cc: linux-omap@vger.kernel.org, Steve Sakoman <steve@sakoman.com>
Subject: [patch] bugfix: SOUND: SOC: OMAP: Add support for Gumstix Overo
Date: Fri, 3 Oct 2008 08:11:33 -0700 [thread overview]
Message-ID: <200810030811.33484.david-b@pacbell.net> (raw)
From: David Brownell <dbrownell@users.sourceforge.net>
Get rid of bogus ASOC boot messages on non-Overo boards,
such as with a kernel built for both Overo and Beagle.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-By: Steve Sakoman <steve@sakoman.com>
---
I'm not sure where the four patches for Overo support are
in the ALSA queue (that's how they'll merge, yes?) but I'll
suggest this one merge into the initial "overo.c" submit...
sound/soc/omap/overo.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/sound/soc/omap/overo.c
+++ b/sound/soc/omap/overo.c
@@ -107,11 +107,11 @@ static int __init overo_soc_init(void)
{
int ret;
- printk(KERN_INFO "overo SoC init\n");
if (!machine_is_overo()) {
- printk(KERN_ERR "Not Overo!\n");
+ pr_debug("Not Overo!\n");
return -ENODEV;
}
+ printk(KERN_INFO "overo SoC init\n");
overo_snd_device = platform_device_alloc("soc-audio", -1);
if (!overo_snd_device) {
@@ -135,13 +135,12 @@ err1:
return ret;
}
+module_init(overo_soc_init);
static void __exit overo_soc_exit(void)
{
platform_device_unregister(overo_snd_device);
}
-
-module_init(overo_soc_init);
module_exit(overo_soc_exit);
MODULE_AUTHOR("Steve Sakoman <steve@sakoman.com>");
next reply other threads:[~2008-10-03 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 15:11 David Brownell [this message]
2008-10-03 15:18 ` [alsa-devel] [patch] bugfix: SOUND: SOC: OMAP: Add support for Gumstix Overo Mark Brown
2008-10-03 15:37 ` David Brownell
2008-10-03 17:49 ` Mark Brown
2008-10-04 7:10 ` Tony Lindgren
2008-10-06 6:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810030811.33484.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.