Re: [alsa-devel] [patch] bugfix: SOUND: SOC: OMAP: Add support for Gumstix Overo

[Mark Brown <broonie@sirena.org.uk>]

On Fri, Oct 03, 2008 at 08:11:33AM -0700, David Brownell wrote:

> Get rid of bogus ASOC boot messages on non-Overo boards,
> such as with a kernel built for both Overo and Beagle.

<nitpick>It's ASoC, not ASOC.</nitpick>

> ---
> I'm not sure where the four patches for Overo support are
> in the ALSA queue (that's how they'll merge, yes?) but I'll
> suggest this one merge into the initial "overo.c" submit...

They're not queued in ALSA since they depend on the PMIC codec driver
which in turn depends on the PMIC core driver being merged.  The change
looks good, FWIW but...

> @@ -135,13 +135,12 @@ err1:
>  
>  	return ret;
>  }
> +module_init(overo_soc_init);
>  
>  static void __exit overo_soc_exit(void)
>  {
>  	platform_device_unregister(overo_snd_device);
>  }
> -
> -module_init(overo_soc_init);
>  module_exit(overo_soc_exit);

This is a reasonable change but unrelated to your patch description.