From: Amit Shah <amit.shah@redhat.com>
To: Sheng Yang <yasker@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, "Yang, Sheng" <sheng.yang@intel.com>,
"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>,
sheng@linux.intel.com
Subject: Re: [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip
Date: Fri, 3 Oct 2008 16:17:54 +0530 [thread overview]
Message-ID: <200810031617.54294.amit.shah@redhat.com> (raw)
In-Reply-To: <20081003103754.GA29951@yukikaze>
* On Friday 03 Oct 2008 16:07:54 Sheng Yang wrote:
> > Just one thing: can you make the irq_source_id argument the 3rd one and
> > the 'level' as the last one? It's clearer to think of it that way.
>
> Yeah, put the irq_source_id at the end of parameter list is a little ugly.
> But I think it's better to keep "irq" and "level" together, so I move
> irq_souce_id to the 2nd place. :)
I think that's even better.
next prev parent reply other threads:[~2008-10-03 10:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 8:19 [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip Yang, Sheng
2008-10-02 13:27 ` Avi Kivity
2008-10-02 14:06 ` Sheng Yang
2008-10-02 16:45 ` Sheng Yang
2008-10-03 7:36 ` Amit Shah
2008-10-03 10:37 ` Sheng Yang
2008-10-03 10:47 ` Amit Shah [this message]
2008-10-04 8:45 ` Avi Kivity
2008-10-04 8:47 ` Avi Kivity
2008-10-06 6:23 ` Sheng Yang
2008-10-06 6:37 ` Sheng Yang
2008-10-10 12:12 ` Amit Shah
2008-10-08 8:29 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810031617.54294.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
--cc=sheng@linux.intel.com \
--cc=yasker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.