All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sheng Yang <sheng@linux.intel.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
	"'kvm@vger.kernel.org'" <kvm@vger.kernel.org>
Subject: Re: [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip
Date: Wed, 8 Oct 2008 16:29:59 +0800	[thread overview]
Message-ID: <200810081629.59746.sheng@linux.intel.com> (raw)
In-Reply-To: <200810031306.53295.amit.shah@redhat.com>

On Friday 03 October 2008 15:36:53 Amit Shah wrote:
> * On Thursday 02 Oct 2008 22:15:59 Sheng Yang wrote:
> >  /* This should be called with the kvm->lock mutex held */
> > -void kvm_set_irq(struct kvm *kvm, int irq, int level)
> > +void kvm_set_irq(struct kvm *kvm, int irq, int level, int irq_source_id)
>
> Just one thing: can you make the irq_source_id argument the 3rd one and
> the 'level' as the last one? It's clearer to think of it that way.
>
> I'll test this next week.

Hi, Amit

Do you have any update on this patch?

Thanks!
--
regards
Yang, Sheng

      parent reply	other threads:[~2008-10-08  8:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  8:19 [RFC][PATCH 0/2] Fix guest shared interrupt with in-kernel irqchip Yang, Sheng
2008-10-02 13:27 ` Avi Kivity
2008-10-02 14:06   ` Sheng Yang
2008-10-02 16:45   ` Sheng Yang
2008-10-03  7:36     ` Amit Shah
2008-10-03 10:37       ` Sheng Yang
2008-10-03 10:47         ` Amit Shah
2008-10-04  8:45         ` Avi Kivity
2008-10-04  8:47         ` Avi Kivity
2008-10-06  6:23           ` Sheng Yang
2008-10-06  6:37             ` Sheng Yang
2008-10-10 12:12         ` Amit Shah
2008-10-08  8:29       ` Sheng Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810081629.59746.sheng@linux.intel.com \
    --to=sheng@linux.intel.com \
    --cc=amit.shah@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.