All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexander van Heukelum <heukelum@mailshack.com>
Cc: Alexander van Heukelum <heukelum@fastmail.fm>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] dumpstack: x86: various small unification steps
Date: Sun, 5 Oct 2008 18:38:20 +0200	[thread overview]
Message-ID: <20081005163820.GA18055@elte.hu> (raw)
In-Reply-To: <20081005103936.GA15118@mailshack.com>


* Alexander van Heukelum <heukelum@mailshack.com> wrote:

> After "dumpstack: x86: various small unification steps", the
> assembler gives the following compile error. The error is in
> dumpstack_64.c.
> 
> {standard input}: Assembler messages:
> {standard input}:720: Error: Incorrect register `%rbx' used with `l' suffix
> {standard input}:1340: Error: Incorrect register `%r12' used with `l' suffix
> 
> Indeed the suffix in get_bp() was wrong.
> 
> Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>

applied to tip/x86/dumpstack, thanks. I've again started testing it.

	Ingo

  reply	other threads:[~2008-10-05 16:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04 21:12 [PATCH] dumpstack: x86: various small unification steps Alexander van Heukelum
2008-10-04 21:12 ` [PATCH] dumpstack: x86: move die_nmi to dumpstack_32.c Alexander van Heukelum
2008-10-04 21:12   ` [PATCH] dumpstack: x86: make printk_address equal Alexander van Heukelum
2008-10-04 21:12     ` [PATCH] dumpstack: x86: add "end" parameter to valid_stack_ptr and print_context_stack Alexander van Heukelum
2008-10-04 21:12       ` [PATCH] dumptrace: x86: consistently include loglevel, print stack switch Alexander van Heukelum
2008-10-04 21:12         ` [PATCH] dumpstack: x86: use log_lvl and unify trace formatting Alexander van Heukelum
2008-10-04 21:12           ` [PATCH] dumpstack: i386: make kstack= an early boot-param and add oops=panic Alexander van Heukelum
2008-10-04 21:12             ` [PATCH] dumpstack: x86: various small unification steps Alexander van Heukelum
2008-10-06  9:35               ` Louis Rilling
2008-10-06  9:43                 ` Alexander van Heukelum
2008-10-05  9:35 ` Ingo Molnar
2008-10-05  9:46   ` Ingo Molnar
2008-10-05 10:39     ` Alexander van Heukelum
2008-10-05 16:38       ` Ingo Molnar [this message]
2008-10-05 11:40   ` Alexander van Heukelum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081005163820.GA18055@elte.hu \
    --to=mingo@elte.hu \
    --cc=heukelum@fastmail.fm \
    --cc=heukelum@mailshack.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.