From: Nick Piggin <npiggin@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
netdev@vger.kernel.org, Paul McKenney <paulmck@us.ibm.com>
Subject: Re: [patch][rfc] ddds: "dynamic dynamic data structure" algorithm, for adaptive dcache hash table sizing (resend)
Date: Tue, 7 Oct 2008 09:53:09 +0200 [thread overview]
Message-ID: <20081007075309.GA16143@wotan.suse.de> (raw)
In-Reply-To: <20081007071827.GB5010@infradead.org>
On Tue, Oct 07, 2008 at 03:18:27AM -0400, Christoph Hellwig wrote:
> >
> > I'm cc'ing netdev because Dave did express some interest in using this for
> > some networking hashes, and network guys in general are pretty cluey when it
> > comes to hashes and such ;)
>
> Without even looking at the code I'd say geeting the dcache lookup data
> structure as a hash is the main problem here. Dcache lookup is
> fundamentally a tree lookup, with some very nice domain splits
> (superblocks or directories).
Dcache lookup is partially a tree lookup, but also how do you look up
entries in a given directory? That is not naturally a tree lookup. Could
be a per directory tree, though, or a hash, or trie.
Anyway, I don't volunteer to change that just yet ;)
> Mapping these back to a global hash is
> a rather bad idea, not just for scalability purposes.
I don't disagree. But it can be improved by dynamically resizing
until it is replaced. I guess it is also a demonstration of how to
implement the algorithm.
PID hash is probably another good one to convert.
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
netdev@vger.kernel.org, Paul McKenney <paulmck@us.ibm.com>
Subject: Re: [patch][rfc] ddds: "dynamic dynamic data structure" algorithm, for adaptive dcache hash table sizing (resend)
Date: Tue, 7 Oct 2008 09:53:09 +0200 [thread overview]
Message-ID: <20081007075309.GA16143@wotan.suse.de> (raw)
In-Reply-To: <20081007071827.GB5010@infradead.org>
On Tue, Oct 07, 2008 at 03:18:27AM -0400, Christoph Hellwig wrote:
> >
> > I'm cc'ing netdev because Dave did express some interest in using this for
> > some networking hashes, and network guys in general are pretty cluey when it
> > comes to hashes and such ;)
>
> Without even looking at the code I'd say geeting the dcache lookup data
> structure as a hash is the main problem here. Dcache lookup is
> fundamentally a tree lookup, with some very nice domain splits
> (superblocks or directories).
Dcache lookup is partially a tree lookup, but also how do you look up
entries in a given directory? That is not naturally a tree lookup. Could
be a per directory tree, though, or a hash, or trie.
Anyway, I don't volunteer to change that just yet ;)
> Mapping these back to a global hash is
> a rather bad idea, not just for scalability purposes.
I don't disagree. But it can be improved by dynamically resizing
until it is replaced. I guess it is also a demonstration of how to
implement the algorithm.
PID hash is probably another good one to convert.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-07 7:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 6:48 [patch][rfc] ddds: "dynamic dynamic data structure" algorithm, for adaptive dcache hash table sizing Nick Piggin
2008-10-07 6:48 ` Nick Piggin
2008-10-07 7:02 ` [patch][rfc] ddds: "dynamic dynamic data structure" algorithm, for adaptive dcache hash table sizing (resend) Nick Piggin
2008-10-07 7:02 ` Nick Piggin
2008-10-07 7:18 ` Christoph Hellwig
2008-10-07 7:18 ` Christoph Hellwig
2008-10-07 7:53 ` Nick Piggin [this message]
2008-10-07 7:53 ` Nick Piggin
2008-10-07 21:06 ` David Miller
2008-10-07 21:06 ` David Miller, Nick Piggin
2008-10-07 15:37 ` Mikael Pettersson
2008-10-07 15:37 ` Mikael Pettersson
2008-10-07 16:39 ` Nick Piggin
2008-10-07 16:39 ` Nick Piggin
2008-10-07 7:37 ` Eric Dumazet
2008-10-07 7:37 ` Eric Dumazet
2008-10-07 8:06 ` Nick Piggin
2008-10-07 8:06 ` Nick Piggin
2008-10-07 21:05 ` David Miller
2008-10-07 21:05 ` David Miller, Nick Piggin
2008-10-08 2:38 ` Nick Piggin
2008-10-08 2:38 ` Nick Piggin
2008-10-07 21:08 ` [patch][rfc] ddds: "dynamic dynamic data structure" algorithm, for adaptive dcache hash table sizing David Miller
2008-10-07 21:08 ` David Miller, Nick Piggin
2008-10-08 2:48 ` Nick Piggin
2008-10-08 2:48 ` Nick Piggin
2008-10-08 3:12 ` Paul E. McKenney
2008-10-08 3:12 ` Paul E. McKenney
2008-10-08 3:27 ` Nick Piggin
2008-10-08 3:27 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007075309.GA16143@wotan.suse.de \
--to=npiggin@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.