From: David Brownell <david-b@pacbell.net>
To: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/3] Move twl4030 scripts to platform data
Date: Tue, 7 Oct 2008 09:05:43 -0700 [thread overview]
Message-ID: <200810070905.43912.david-b@pacbell.net> (raw)
In-Reply-To: <1223390050-11499-1-git-send-email-peter.de-schrijver@nokia.com>
On Tuesday 07 October 2008, Peter 'p2' De Schrijver wrote:
> This patch set move the twl4030 scripts to platform data
> and integrates the code to download the scripts with the
> new twl4030 codebase.
>
> Peter 'p2' De Schrijver (3):
> Add twl4030 scripts to 3430sdp platform data
> Adapt twl4030 power code to new twl4030 code
> Add twl4030 power platform device
Good. Those scripts were absolutely not in the
right kind of location before!
Your patch comments are all rather uniformly
empty though, worth fixing ...
... and patch #1 (add scripts) breaks compiles,
it should include the header update from #2.
And I'll suggest a patch #4 to move this from
the drivers/i2c/chips directory to someplace
more appropriate. Not that I have a sugggestion
on where; but drivers/i2c is clearly wrong!
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-10-07 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 14:34 [PATCH 0/3] Move twl4030 scripts to platform data Peter 'p2' De Schrijver
2008-10-07 14:34 ` [PATCH 1/3] Add twl4030 scripts to 3430sdp " Peter 'p2' De Schrijver
2008-10-07 14:34 ` [PATCH 2/3] Adapt twl4030 power code to new twl4030 code Peter 'p2' De Schrijver
2008-10-07 14:34 ` [PATCH 3/3] Add twl4030 power platform device Peter 'p2' De Schrijver
2008-10-07 16:19 ` [PATCH 2/3] Adapt twl4030 power code to new twl4030 code David Brownell
2008-10-08 6:49 ` Peter 'p2' De Schrijver
2008-10-08 7:16 ` David Brownell
2008-10-08 7:22 ` David Brownell
2008-11-08 0:05 ` David Brownell
2008-10-07 16:05 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810070905.43912.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=peter.de-schrijver@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.