Re: [PATCH 2/3] Adapt twl4030 power code to new twl4030 code

[David Brownell <david-b@pacbell.net>]

On Tuesday 07 October 2008, Peter 'p2' De Schrijver wrote:
> > And I can't help but wonder why this isn't just part of
> > the twl4030-core code, without even a platform device/driver.
> 
> If you think all this script loading stuff can go into twl4030-core, I
> can make a patch to move it there.

Well, link it with twl-core, call it as a subroutine,
add some kind of header to hold the subroutine decl.
Not unlike the linkage structure "today".

Right now I'm thinking the {core, irq, "power"} structure
will be OK, if the "irq" gets generalized so it's not just
the one SIH module (which I have, partially done) ... and
the "power" bits lose the board-specific stuff.

 
> > I didn't move it to drivers/mfd because it seemed almost all
> > SDP-specific.  But to the extent that it's something generic
> > and "part of the core", maybe that's where it should be.
> > Not necessarily part of the same file.
> > 
> 
> It's not SDP specific, but it is OMAP specific I think. At least I can't
> see use cases outside OMAP2/3.

We'll know when/if this is used on non-OMAP hardware!

Likely not soon.  I'd like to have the code build cleanly
on most hardware, so we get the build fixes and API update
that implies.  That's mostly IRQ cleanup.  Board designers
will do what they want, and I suspect you're right there.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html