From: Arnd Bergmann <arnd@arndb.de>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, "Paoletti,
Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
Subject: Re: [PATCH] serial: Add Cavium OCTEON UART definitions.
Date: Tue, 7 Oct 2008 11:34:50 +0200 [thread overview]
Message-ID: <200810071134.51012.arnd@arndb.de> (raw)
In-Reply-To: <48EAAF97.8050307@caviumnetworks.com>
On Tuesday 07 October 2008, David Daney wrote:
>
> - up->port.type = PORT_16550A;
> +#ifdef CONFIG_CPU_CAVIUM_OCTEON
> + /* UPF_FIXED_PORT indicates an internal UART. */
> + if (up->port.flags & UPF_FIXED_PORT)
> + up->port.type = PORT_OCTEON;
> + else
> +#endif
> + up->port.type = PORT_16550A;
> +
This looks somewhat wrong, IMHO a device driver should not assume that
a CONFIG_CPU_* symbol is exclusive. You could have (maybe not now, but
in the future) a kernel that supports running on an Octeon as well
as some other Mips64 processor, and have UPF_FIXED_PORT uart on some
other machine, which will make the kernel think it is a PORT_OCTEON.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: David Daney <ddaney@caviumnetworks.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, "Paoletti,
Tomaso" <Tomaso.Paoletti@caviumnetworks.com>
Subject: Re: [PATCH] serial: Add Cavium OCTEON UART definitions.
Date: Tue, 7 Oct 2008 11:34:50 +0200 [thread overview]
Message-ID: <200810071134.51012.arnd@arndb.de> (raw)
In-Reply-To: <48EAAF97.8050307@caviumnetworks.com>
On Tuesday 07 October 2008, David Daney wrote:
>
> - up->port.type = PORT_16550A;
> +#ifdef CONFIG_CPU_CAVIUM_OCTEON
> + /* UPF_FIXED_PORT indicates an internal UART. */
> + if (up->port.flags & UPF_FIXED_PORT)
> + up->port.type = PORT_OCTEON;
> + else
> +#endif
> + up->port.type = PORT_16550A;
> +
This looks somewhat wrong, IMHO a device driver should not assume that
a CONFIG_CPU_* symbol is exclusive. You could have (maybe not now, but
in the future) a kernel that supports running on an Octeon as well
as some other Mips64 processor, and have UPF_FIXED_PORT uart on some
other machine, which will make the kernel think it is a PORT_OCTEON.
Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-07 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 0:38 [PATCH] serial: Add Cavium OCTEON UART definitions David Daney
2008-10-07 9:34 ` Arnd Bergmann [this message]
2008-10-07 9:34 ` Arnd Bergmann
2008-10-07 10:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810071134.51012.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Tomaso.Paoletti@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.