All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Christian Pellegrin <chripell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: chripell-VaTbYqLCNhc@public.gmane.org,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND] MAX3100 SPI UART driver
Date: Wed, 8 Oct 2008 14:26:37 -0700	[thread overview]
Message-ID: <20081008142637.10bc821d.akpm@linux-foundation.org> (raw)
In-Reply-To: <12229367533638-git-send-email-chripell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Thu,  2 Oct 2008 10:39:13 +0200
Christian Pellegrin <chripell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> This patch adds support for the MAX3100 SPI UART. I am still
> waiting for a minor number from device-7qcCgDSrTd8dnm+yROfE0A@public.gmane.org so that
> may change.
> 

Both Alan and I had numerous review comments on the previous version of
this patch.

You have not sent us a point-by-point response to those review comments
which forces us to a) go back and see what all the comments were then
b) check the patch to see if/how each point was addressed.  Needless to
say, that's not a ton of fun for us.

Can you please reply to our earlier emails and let us know what changes
were made against each review comment?

Thanks.


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Christian Pellegrin <chripell@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	spi-devel-general@lists.sourceforge.net,
	alan@lxorguk.ukuu.org.uk, chripell@fsfe.org
Subject: Re: [PATCH RESEND] MAX3100 SPI UART driver
Date: Wed, 8 Oct 2008 14:26:37 -0700	[thread overview]
Message-ID: <20081008142637.10bc821d.akpm@linux-foundation.org> (raw)
In-Reply-To: <12229367533638-git-send-email-chripell@gmail.com>

On Thu,  2 Oct 2008 10:39:13 +0200
Christian Pellegrin <chripell@gmail.com> wrote:

> This patch adds support for the MAX3100 SPI UART. I am still
> waiting for a minor number from device@lanana.org so that
> may change.
> 

Both Alan and I had numerous review comments on the previous version of
this patch.

You have not sent us a point-by-point response to those review comments
which forces us to a) go back and see what all the comments were then
b) check the patch to see if/how each point was addressed.  Needless to
say, that's not a ton of fun for us.

Can you please reply to our earlier emails and let us know what changes
were made against each review comment?

Thanks.


  parent reply	other threads:[~2008-10-08 21:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  8:39 [PATCH RESEND] MAX3100 SPI UART driver Christian Pellegrin
     [not found] ` <12229367533638-git-send-email-chripell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-10-08 21:26   ` Andrew Morton [this message]
2008-10-08 21:26     ` Andrew Morton
2008-10-09  5:44     ` chri
2009-01-09 22:21   ` Andrew Morton
2009-01-09 22:21     ` Andrew Morton
2009-01-10 18:49     ` christian pellegrin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081008142637.10bc821d.akpm@linux-foundation.org \
    --to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=chripell-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=chripell-VaTbYqLCNhc@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.