Re: [RFC PATCH] rtl8187: do not report ACKs if USB Tx status is non-zero

["John W. Linville" <linville@tuxdriver.com>]

On Tue, Oct 07, 2008 at 03:18:18PM -0400, John W. Linville wrote:
> The vendor-supplied driver treats a USB Tx failure as an un-ACKed frame.
> I don't see why we shouldn't do the same thing -- hopefully this makes
> rate-scaling algorithms behave sanely with the rtl8187 driver.
> 
> Thanks to Felix Fietkau <nbd@openwrt.org> for suggesting this as an
> option.
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> This is currently untested -- anyone with rtl8187 bored enough to try
> it? :-)
 
AFAICT, this doesn't actually trigger -- at least, the device can
go into its typical failure mode (no frames ACKed until you force a
lower rate) without ever hitting the "assume ACK not received" clause.

I'll keep looking at it -- there are a couple of 'secrets' still
buried in the vendor driver (if I can stomach to keep looking at it)...

John
-- 
John W. Linville		Linux should be at the core
linville@tuxdriver.com			of your literate lifestyle.