From: "John W. Linville" <linville@tuxdriver.com>
To: "Stefanik Gábor" <netrolller.3d@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] rtl8187: do not report ACKs if USB Tx status is non-zero
Date: Wed, 8 Oct 2008 16:02:50 -0400 [thread overview]
Message-ID: <20081008200250.GD32472@tuxdriver.com> (raw)
In-Reply-To: <69e28c910810081238m612ece22l2c26b38a88aba608@mail.gmail.com>
On Wed, Oct 08, 2008 at 09:38:49PM +0200, Stefanik G=E1bor wrote:
> Another weird thing: the code above essentially attempts to do this:
> Wait for an ACK
> If not TX_CTL_NO_ACK:
> If acked:
> Report the packet as acked.
> Endif
> If no ACK until timeout:
> Report packet as unacked
> Endif
> Endif
>=20
> This would be better, as it doesn't waste time waiting for an ACK for
> unacked frames:
>=20
> If not TX_CTL_NO_ACK:
> Wait for an ACK
> If acked:
> Report the packet as acked.
> Endif
> If no ACK until timeout:
> Report packet as unacked
> Endif
> Endif
>=20
> Of course, this only works if "Wait for an ACK" actually works.
Well as I understand it, the only waiting is related to the URB
submission (which is asynchronous anyway). I don't really see how
we could avoid it.
John
--=20
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-08 20:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 19:18 [RFC PATCH] rtl8187: do not report ACKs if USB Tx status is non-zero John W. Linville
2008-10-08 18:42 ` John W. Linville
2008-10-08 19:38 ` Stefanik Gábor
2008-10-08 20:02 ` John W. Linville [this message]
2008-10-08 22:48 ` Herton Ronaldo Krzesinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008200250.GD32472@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.