Re: [PATCH 07/07] ARM: OMAP2: Fix sparse, checkpatch warnings in OMAP2/3 IRQ code

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Fri, Oct 03, 2008 at 02:56:49PM +0300, Tony Lindgren wrote:
> Fix sparse warnings in mach-omap2/irq.c. Fix by defining
> intc_bank_write_reg() and intc_bank_read_reg(), and convert INTC module
> register access to use them rather than __raw_{read,write}l.

This is not a fix.
> +/* INTC bank register get/set */
> +
> +static void intc_bank_write_reg(u32 val, struct omap_irq_bank *bank, u16 reg)
> +{
> +	__raw_writel(val, (__force void __iomem *)(bank->base_reg + reg));
> +}
> +
> +static u32 intc_bank_read_reg(struct omap_irq_bank *bank, u16 reg)
> +{
> +	return __raw_readl((__force void __iomem *)(bank->base_reg + reg));

Because it uses __force here.  In my tree, bank->base_reg is defined
to be:

        void __iomem *base_reg;

So these cases are entirely unnecessary.  As I've said before, use of
__force is generally a sure sign of doing something wrong.