All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP2xxx: move SRAM to fix boot hang
       [not found] <20081009232100.13509.6688.stgit@localhost.localdomain>
@ 2008-10-09 23:22 ` Paul Walmsley
  2008-10-10 11:24   ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2008-10-09 23:22 UTC (permalink / raw)
  To: linux-omap
  Cc: Paul Walmsley, Kevin Hilman, Jarkko Nikula, Tony Lindgren,
	MånsRullgård

Commit 1c957036bbd912322793da676d05e169abf24782 breaks booting on
OMAP2; it causes the SRAM to be mapped on top of the L4 interconnect.
This causes the system to hang early in boot in omap_map_sram() during
the TLB flush. Fix by moving SRAM elsewhere in the memory map.

Reported by Jarkko Nikula <jarkko.nikula@nokia.com>.  This patch is a
collaboration with Tony Lindgren <tony@atomide.com> and
Kevin Hilman <khilman@deeprootsystems.com>.

Boot-tested on 2430SDP (by Paul) and N810 (by Jarkko).

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Tested-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Måns Rullgård <mans@mansr.com>
---
 arch/arm/plat-omap/sram.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index 853048d..027b101 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -37,8 +37,8 @@
 #define OMAP1_SRAM_VA		VMALLOC_END
 #define OMAP2_SRAM_PA		0x40200000
 #define OMAP2_SRAM_PUB_PA	0x4020f800
-#define OMAP2_SRAM_VA		VMALLOC_END
-#define OMAP2_SRAM_PUB_VA	(VMALLOC_END + 0x800)
+#define OMAP2_SRAM_VA		0xe3000000
+#define OMAP2_SRAM_PUB_VA	(OMAP2_SRAM_VA + 0x800)
 #define OMAP3_SRAM_PA           0x40200000
 #define OMAP3_SRAM_VA           0xd7000000
 #define OMAP3_SRAM_PUB_PA       0x40208000


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OMAP2xxx: move SRAM to fix boot hang
  2008-10-09 23:22 ` [PATCH] OMAP2xxx: move SRAM to fix boot hang Paul Walmsley
@ 2008-10-10 11:24   ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2008-10-10 11:24 UTC (permalink / raw)
  To: Paul Walmsley
  Cc: linux-omap, Kevin Hilman, Jarkko Nikula, MånsRullgård

* Paul Walmsley <paul@pwsan.com> [081010 02:23]:
> Commit 1c957036bbd912322793da676d05e169abf24782 breaks booting on
> OMAP2; it causes the SRAM to be mapped on top of the L4 interconnect.
> This causes the system to hang early in boot in omap_map_sram() during
> the TLB flush. Fix by moving SRAM elsewhere in the memory map.
> 
> Reported by Jarkko Nikula <jarkko.nikula@nokia.com>.  This patch is a
> collaboration with Tony Lindgren <tony@atomide.com> and
> Kevin Hilman <khilman@deeprootsystems.com>.
> 
> Boot-tested on 2430SDP (by Paul) and N810 (by Jarkko).

Pushing.

Tony

> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Tested-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Måns Rullgård <mans@mansr.com>
> ---
>  arch/arm/plat-omap/sram.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index 853048d..027b101 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -37,8 +37,8 @@
>  #define OMAP1_SRAM_VA		VMALLOC_END
>  #define OMAP2_SRAM_PA		0x40200000
>  #define OMAP2_SRAM_PUB_PA	0x4020f800
> -#define OMAP2_SRAM_VA		VMALLOC_END
> -#define OMAP2_SRAM_PUB_VA	(VMALLOC_END + 0x800)
> +#define OMAP2_SRAM_VA		0xe3000000
> +#define OMAP2_SRAM_PUB_VA	(OMAP2_SRAM_VA + 0x800)
>  #define OMAP3_SRAM_PA           0x40200000
>  #define OMAP3_SRAM_VA           0xd7000000
>  #define OMAP3_SRAM_PUB_PA       0x40208000
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-10 11:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20081009232100.13509.6688.stgit@localhost.localdomain>
2008-10-09 23:22 ` [PATCH] OMAP2xxx: move SRAM to fix boot hang Paul Walmsley
2008-10-10 11:24   ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.