[PATCH 1/1] ARM: OMAP: fix uninitialized warning

[PATCH 1/1] ARM: OMAP: fix uninitialized warning

[Hiroshi DOYU]

warning: 'rev_name' may be used uninitialized in this function

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 arch/arm/mach-omap2/id.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 7a7ad18..c002076 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -147,7 +147,7 @@ void __init omap34xx_check_revision(void)
 	u32 cpuid, idcode;
 	u16 hawkeye;
 	u8 rev;
-	char *rev_name;
+	char *rev_name = "ES1.0";
 
 	/*
 	 * We cannot access revision registers on ES1.0.
@@ -157,7 +157,6 @@ void __init omap34xx_check_revision(void)
 	cpuid = read_cpuid(CPUID_ID);
 	if ((((cpuid >> 4) & 0xfff) == 0xc08) && ((cpuid & 0xf) == 0x0)) {
 		system_rev = OMAP3430_REV_ES1_0;
-		rev_name = "ES1.0";
 		goto out;
 	}
 
-- 
1.6.0.2.229.g1293c

Re: [PATCH 1/1] ARM: OMAP: fix uninitialized warning

[Tony Lindgren]

* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [081009 14:38]:
> warning: 'rev_name' may be used uninitialized in this function

Pushing.

Tony

> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
>  arch/arm/mach-omap2/id.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 7a7ad18..c002076 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -147,7 +147,7 @@ void __init omap34xx_check_revision(void)
>  	u32 cpuid, idcode;
>  	u16 hawkeye;
>  	u8 rev;
> -	char *rev_name;
> +	char *rev_name = "ES1.0";
>  
>  	/*
>  	 * We cannot access revision registers on ES1.0.
> @@ -157,7 +157,6 @@ void __init omap34xx_check_revision(void)
>  	cpuid = read_cpuid(CPUID_ID);
>  	if ((((cpuid >> 4) & 0xfff) == 0xc08) && ((cpuid & 0xf) == 0x0)) {
>  		system_rev = OMAP3430_REV_ES1_0;
> -		rev_name = "ES1.0";
>  		goto out;
>  	}
>  
> -- 
> 1.6.0.2.229.g1293c
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] ARM: OMAP: fix uninitialized warning

[Hiroshi DOYU]

warning: 'pixel' may be used uninitialized in this function

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 drivers/video/omap/lcd_mipid.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
index 5dcca82..8b11f73 100644
--- a/drivers/video/omap/lcd_mipid.c
+++ b/drivers/video/omap/lcd_mipid.c
@@ -267,7 +267,7 @@ static unsigned long mipid_get_caps(struct lcd_panel *panel)
 
 static u16 read_first_pixel(struct mipid_device *md)
 {
-	u16 pixel;
+	u16 uninitialized_var(pixel);
 	u8 red, green, blue;
 
 	mutex_lock(&md->mutex);
-- 
1.6.0.2.229.g1293c