All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: "Woodruff, Richard" <r-woodruff2@ti.com>,
	Steve Sakoman <sakoman@gmail.com>,
	Anand Gadiyar <gadiyar@gmail.com>,
	linux-omap@vger.kernel.org
Subject: Re: [patch 2.6.27-rc8-omap 0/7] resend of pending TWL patches
Date: Sun, 12 Oct 2008 10:24:14 -0700	[thread overview]
Message-ID: <200810121024.14981.david-b@pacbell.net> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC3560870239624AC3@dbde02.ent.ti.com>

On Sunday 12 October 2008, Pandita, Vikram wrote:
> >> >         /* Wait for TLL to be Active */
> >> >         while ((cm_read_mod_reg(CORE_MOD, OMAP2430_CM_IDLEST3) &
> >> >                 (1 << OMAP3430ES2_ST_USBTLL_SHIFT)));
> >>
> >> Fishy ... TLL == TransceiverLess Link, which is used with
> >> on-board links that don't need to be morphed to use signals
> >> that go over cables as defined in the USB spec.  I would
> >> think you'd want ULPI.
> >
> >TLL block does get used for some cases for non-tll (phy) mode use.  
> 
> In particular, clocking mode used for EHCI on omap34xx is input clocking mode.
> This means OMAP feeds the 60Mhz clock and TLL module is used to generate the 60Mhz clock.
> So irrespective of TLL or ULPI-PHY mode, TLL block has to be kept up.

OK ... I suggest a comment in the code explaining that,
so it's clear what's going on.

Along with whatever fix is needed to allow booting with
EHCI enabled again.  Something seems to be preventing
TLL from coming up now...


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-10-12 17:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 15:57 [patch 2.6.27-rc8-omap 0/7] resend of pending TWL patches David Brownell
2008-10-03 16:42 ` David Brownell
     [not found]   ` <57969b5c0810031036q55075fdbw259159757f25c863@mail.gmail.com>
2008-10-03 17:38     ` Anand Gadiyar
2008-10-03 17:59       ` Marek Vasut
2008-10-06  6:41         ` Tony Lindgren
2008-10-06 23:26       ` David Brownell
2008-10-12  4:33         ` Steve Sakoman
2008-10-12  6:43           ` David Brownell
2008-10-12 13:21             ` Woodruff, Richard
2008-10-12 16:45               ` Pandita, Vikram
2008-10-12 17:24                 ` David Brownell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810121024.14981.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=gadiyar@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=r-woodruff2@ti.com \
    --cc=sakoman@gmail.com \
    --cc=vikram.pandita@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.