From: "John W. Linville" <linville@tuxdriver.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] wireless: build failure if !CONFIG_MAC80211_MESH
Date: Mon, 13 Oct 2008 12:36:42 -0400 [thread overview]
Message-ID: <20081013163642.GA32550@tuxdriver.com> (raw)
In-Reply-To: <20081013084503.66cca9f9@extreme>
I think Dave already merged a patch from Ingo to resolve this issue?
On Mon, Oct 13, 2008 at 08:45:03AM -0700, Stephen Hemminger wrote:
> If mac80211 is configured, but MAC80211_MESH is not, then the build fails
> because mesh_path_lookup and mesh_path_add are not defined.
> Compile tested only, fixes the build, but no idea if breaks something else.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> ---
> Also needed to stub out mpp_path_lookup
>
> --- a/net/mac80211/mesh.h 2008-10-13 07:57:46.000000000 -0700
> +++ b/net/mac80211/mesh.h 2008-10-13 08:42:31.000000000 -0700
> @@ -225,11 +225,20 @@ void ieee80211_stop_mesh(struct ieee8021
> int mesh_nexthop_lookup(struct sk_buff *skb,
> struct ieee80211_sub_if_data *sdata);
> void mesh_path_start_discovery(struct ieee80211_sub_if_data *sdata);
> +#ifdef CONFIG_MAC80211_MESH
> struct mesh_path *mesh_path_lookup(u8 *dst,
> struct ieee80211_sub_if_data *sdata);
> struct mesh_path *mpp_path_lookup(u8 *dst,
> struct ieee80211_sub_if_data *sdata);
> +#else
> +#define mesh_path_lookup(dst,sdata) (NULL)
> +#define mpp_path_lookup(dst,sdata) (NULL)
> +#endif
> +#ifdef CONFIG_MAC80211_MESH
> int mpp_path_add(u8 *dst, u8 *mpp, struct ieee80211_sub_if_data *sdata);
> +#else
> +#define mpp_path_add(dst, mpp, sdata) (-ENOTSUPP)
> +#endif
> struct mesh_path *mesh_path_lookup_by_idx(int idx,
> struct ieee80211_sub_if_data *sdata);
> void mesh_path_fix_nexthop(struct mesh_path *mpath, struct sta_info *next_hop);
>
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] wireless: build failure if !CONFIG_MAC80211_MESH
Date: Mon, 13 Oct 2008 12:36:42 -0400 [thread overview]
Message-ID: <20081013163642.GA32550@tuxdriver.com> (raw)
In-Reply-To: <20081013084503.66cca9f9@extreme>
I think Dave already merged a patch from Ingo to resolve this issue?
On Mon, Oct 13, 2008 at 08:45:03AM -0700, Stephen Hemminger wrote:
> If mac80211 is configured, but MAC80211_MESH is not, then the build fails
> because mesh_path_lookup and mesh_path_add are not defined.
> Compile tested only, fixes the build, but no idea if breaks something else.
>
> Signed-off-by: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
>
> ---
> Also needed to stub out mpp_path_lookup
>
> --- a/net/mac80211/mesh.h 2008-10-13 07:57:46.000000000 -0700
> +++ b/net/mac80211/mesh.h 2008-10-13 08:42:31.000000000 -0700
> @@ -225,11 +225,20 @@ void ieee80211_stop_mesh(struct ieee8021
> int mesh_nexthop_lookup(struct sk_buff *skb,
> struct ieee80211_sub_if_data *sdata);
> void mesh_path_start_discovery(struct ieee80211_sub_if_data *sdata);
> +#ifdef CONFIG_MAC80211_MESH
> struct mesh_path *mesh_path_lookup(u8 *dst,
> struct ieee80211_sub_if_data *sdata);
> struct mesh_path *mpp_path_lookup(u8 *dst,
> struct ieee80211_sub_if_data *sdata);
> +#else
> +#define mesh_path_lookup(dst,sdata) (NULL)
> +#define mpp_path_lookup(dst,sdata) (NULL)
> +#endif
> +#ifdef CONFIG_MAC80211_MESH
> int mpp_path_add(u8 *dst, u8 *mpp, struct ieee80211_sub_if_data *sdata);
> +#else
> +#define mpp_path_add(dst, mpp, sdata) (-ENOTSUPP)
> +#endif
> struct mesh_path *mesh_path_lookup_by_idx(int idx,
> struct ieee80211_sub_if_data *sdata);
> void mesh_path_fix_nexthop(struct mesh_path *mpath, struct sta_info *next_hop);
>
--
John W. Linville Linux should be at the core
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2008-10-13 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081013081238.2755bd25@extreme>
[not found] ` <20081013084503.66cca9f9@extreme>
2008-10-13 16:36 ` John W. Linville [this message]
2008-10-13 16:36 ` [PATCH] wireless: build failure if !CONFIG_MAC80211_MESH John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013163642.GA32550@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.