From: Alex Chiang <achiang@hp.com>
To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jbarnes@virtuousgeek.org, kristen.c.accardi@intel.com,
matthew@wil.cx, kaneshige.kenji@jp.fujitsu.com,
Alex Chiang <achiang@hp.com>
Subject: [PATCH v6-resend 02/17] PCI: rename pci_update_slot_number to pci_renumber_slot
Date: Tue, 14 Oct 2008 01:25:12 -0600 [thread overview]
Message-ID: <20081014072512.24319.50801.stgit@bob.kio> (raw)
In-Reply-To: <20081014072311.24319.27334.stgit@bob.kio>
The GPL exported symbol pci_update_slot_number has been renamed to
pci_renumber_slot. Some of the safety checks were unnecessary and
were removed.
Cc: jbarnes@virtuousgeek.org
Cc: kristen.c.accardi@intel.com
Cc: matthew@wil.cx
Cc: kaneshige.kenji@jp.fujitsu.com
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/pci/slot.c | 15 +++++----------
include/linux/pci.h | 2 +-
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c
index 0c6db03..b9b90ab 100644
--- a/drivers/pci/slot.c
+++ b/drivers/pci/slot.c
@@ -175,7 +175,7 @@ placeholder:
EXPORT_SYMBOL_GPL(pci_create_slot);
/**
- * pci_update_slot_number - update %struct pci_slot -> number
+ * pci_renumber_slot - update %struct pci_slot -> number
* @slot - %struct pci_slot to update
* @slot_nr - new number for slot
*
@@ -183,27 +183,22 @@ EXPORT_SYMBOL_GPL(pci_create_slot);
* created a placeholder slot in pci_create_slot() by passing a -1 as
* slot_nr, to update their %struct pci_slot with the correct @slot_nr.
*/
-
-void pci_update_slot_number(struct pci_slot *slot, int slot_nr)
+void pci_renumber_slot(struct pci_slot *slot, int slot_nr)
{
- int name_count = 0;
struct pci_slot *tmp;
down_write(&pci_bus_sem);
list_for_each_entry(tmp, &slot->bus->slots, list) {
WARN_ON(tmp->number == slot_nr);
- if (!strcmp(kobject_name(&tmp->kobj), kobject_name(&slot->kobj)))
- name_count++;
+ goto out;
}
- if (name_count > 1)
- printk(KERN_WARNING "pci_update_slot_number found %d slots with the same name: %s\n", name_count, kobject_name(&slot->kobj));
-
slot->number = slot_nr;
+out:
up_write(&pci_bus_sem);
}
-EXPORT_SYMBOL_GPL(pci_update_slot_number);
+EXPORT_SYMBOL_GPL(pci_renumber_slot);
/**
* pci_destroy_slot - decrement refcount for physical PCI slot
diff --git a/include/linux/pci.h b/include/linux/pci.h
index cca5700..89f7f90 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -510,7 +510,7 @@ struct pci_bus *pci_add_new_bus(struct pci_bus *parent, struct pci_dev *dev,
struct pci_slot *pci_create_slot(struct pci_bus *parent, int slot_nr,
const char *name);
void pci_destroy_slot(struct pci_slot *slot);
-void pci_update_slot_number(struct pci_slot *slot, int slot_nr);
+void pci_renumber_slot(struct pci_slot *slot, int slot_nr);
int pci_scan_slot(struct pci_bus *bus, int devfn);
struct pci_dev *pci_scan_single_device(struct pci_bus *bus, int devfn);
void pci_device_add(struct pci_dev *dev, struct pci_bus *bus);
next prev parent reply other threads:[~2008-10-14 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 7:25 [PATCH v6-resend 00/17] PCI: let the core manage slot names Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 01/17] PCI Hotplug core: add 'name' param pci_hp_register interface Alex Chiang
2008-10-14 7:25 ` Alex Chiang [this message]
2008-10-14 7:25 ` [PATCH v6-resend 03/17] PCI: update pci_create_slot() to take a 'hotplug' param Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 04/17] PCI Hotplug: serialize pci_hp_register and pci_hp_deregister Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 05/17] PCI: prevent duplicate slot names Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 06/17] PCI, PCI Hotplug: introduce slot_name helpers Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 07/17] PCI: acpiphp: remove 'name' parameter Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 08/17] PCI: cpci_hotplug: stop managing hotplug_slot->name Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 09/17] PCI: cpqphp: " Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 10/17] PCI: fakephp: remove 'name' parameter Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 11/17] PCI: ibmphp: stop managing hotplug_slot->name Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 12/17] PCI: pciehp: remove 'name' parameter Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 13/17] PCI: rpaphp: kmalloc/kfree slot->name directly Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 14/17] PCI: SGI Hotplug: stop managing bss_hotplug_slot->name Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 15/17] PCI: shcphp: remove 'name' parameter Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 16/17] PCI: Hotplug core: remove 'name' Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 17/17] PCI Hotplug: fakephp: add duplicate slot name debugging Alex Chiang
2008-10-15 16:50 ` [PATCH v6-resend 00/17] PCI: let the core manage slot names Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014072512.24319.50801.stgit@bob.kio \
--to=achiang@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.