From: Alex Chiang <achiang@hp.com>
To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jbarnes@virtuousgeek.org, kristen.c.accardi@intel.com,
matthew@wil.cx, kaneshige.kenji@jp.fujitsu.com,
Alex Chiang <achiang@hp.com>
Subject: [PATCH v6-resend 06/17] PCI, PCI Hotplug: introduce slot_name helpers
Date: Tue, 14 Oct 2008 01:25:32 -0600 [thread overview]
Message-ID: <20081014072532.24319.69966.stgit@bob.kio> (raw)
In-Reply-To: <20081014072311.24319.27334.stgit@bob.kio>
In preparation for cleaning up the various hotplug drivers
such that they don't have to manage their own 'name' parameters
anymore, we provide the following convenience functions:
pci_slot_name()
hotplug_slot_name()
These helpers will be used by individual hotplug drivers.
Cc: jbarnes@virtuousgeek.org
Cc: kristen.c.accardi@intel.com
Cc: matthew@wil.cx
Cc: kaneshige.kenji@jp.fujitsu.com
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/pci/slot.c | 2 +-
include/linux/pci.h | 5 +++++
include/linux/pci_hotplug.h | 5 +++++
3 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c
index b6ee352..4dd1c3e 100644
--- a/drivers/pci/slot.c
+++ b/drivers/pci/slot.c
@@ -121,7 +121,7 @@ static int rename_slot(struct pci_slot *slot, const char *name)
int result = 0;
char *slot_name;
- if (strcmp(kobject_name(&slot->kobj), name) == 0)
+ if (strcmp(pci_slot_name(slot), name) == 0)
return result;
slot_name = make_slot_name(name);
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 7150898..29e58ee 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -64,6 +64,11 @@ struct pci_slot {
struct kobject kobj;
};
+static inline const char *pci_slot_name(const struct pci_slot *slot)
+{
+ return kobject_name(&slot->kobj);
+}
+
/* File state for mmap()s on /proc/bus/pci/X/Y */
enum pci_mmap_state {
pci_mmap_io,
diff --git a/include/linux/pci_hotplug.h b/include/linux/pci_hotplug.h
index 5efba66..a3a3245 100644
--- a/include/linux/pci_hotplug.h
+++ b/include/linux/pci_hotplug.h
@@ -165,6 +165,11 @@ struct hotplug_slot {
};
#define to_hotplug_slot(n) container_of(n, struct hotplug_slot, kobj)
+static inline const char *hotplug_slot_name(const struct hotplug_slot *slot)
+{
+ return pci_slot_name(slot->pci_slot);
+}
+
extern int pci_hp_register(struct hotplug_slot *, struct pci_bus *, int nr,
const char *name);
extern int pci_hp_deregister(struct hotplug_slot *slot);
next prev parent reply other threads:[~2008-10-14 7:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 7:25 [PATCH v6-resend 00/17] PCI: let the core manage slot names Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 01/17] PCI Hotplug core: add 'name' param pci_hp_register interface Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 02/17] PCI: rename pci_update_slot_number to pci_renumber_slot Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 03/17] PCI: update pci_create_slot() to take a 'hotplug' param Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 04/17] PCI Hotplug: serialize pci_hp_register and pci_hp_deregister Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 05/17] PCI: prevent duplicate slot names Alex Chiang
2008-10-14 7:25 ` Alex Chiang [this message]
2008-10-14 7:25 ` [PATCH v6-resend 07/17] PCI: acpiphp: remove 'name' parameter Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 08/17] PCI: cpci_hotplug: stop managing hotplug_slot->name Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 09/17] PCI: cpqphp: " Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 10/17] PCI: fakephp: remove 'name' parameter Alex Chiang
2008-10-14 7:25 ` [PATCH v6-resend 11/17] PCI: ibmphp: stop managing hotplug_slot->name Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 12/17] PCI: pciehp: remove 'name' parameter Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 13/17] PCI: rpaphp: kmalloc/kfree slot->name directly Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 14/17] PCI: SGI Hotplug: stop managing bss_hotplug_slot->name Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 15/17] PCI: shcphp: remove 'name' parameter Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 16/17] PCI: Hotplug core: remove 'name' Alex Chiang
2008-10-14 7:26 ` [PATCH v6-resend 17/17] PCI Hotplug: fakephp: add duplicate slot name debugging Alex Chiang
2008-10-15 16:50 ` [PATCH v6-resend 00/17] PCI: let the core manage slot names Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014072532.24319.69966.stgit@bob.kio \
--to=achiang@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.