All of lore.kernel.org
 help / color / mirror / Atom feed
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: Julia Lawall <julia@diku.dk>
Cc: James.Bottomley@HansenPartnership.com,
	linux-scsi@vger.kernel.org, sammy@sammy.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/scsi/sun3x_esp.c: Convert && to ||
Date: Tue, 14 Oct 2008 16:30:07 +0000	[thread overview]
Message-ID: <20081014163007.GA9015@alpha.franken.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0810141759520.20451@pc-004.diku.dk>

On Tue, Oct 14, 2008 at 06:00:19PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> The pattern !E && !E->fld is nonsensical.  The patch below updates this
> according to the assumption that && should be ||.  But perhaps another
> solution was intended.

Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

Thanks for fixing this.
Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

WARNING: multiple messages have this Message-ID (diff)
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: Julia Lawall <julia@diku.dk>
Cc: James.Bottomley@HansenPartnership.com,
	linux-scsi@vger.kernel.org, sammy@sammy.net,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/scsi/sun3x_esp.c: Convert && to ||
Date: Tue, 14 Oct 2008 18:30:07 +0200	[thread overview]
Message-ID: <20081014163007.GA9015@alpha.franken.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0810141759520.20451@pc-004.diku.dk>

On Tue, Oct 14, 2008 at 06:00:19PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> The pattern !E && !E->fld is nonsensical.  The patch below updates this
> according to the assumption that && should be ||.  But perhaps another
> solution was intended.

Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

Thanks for fixing this.
Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2008-10-14 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 16:00 [PATCH 2/2] drivers/scsi/sun3x_esp.c: Convert && to || Julia Lawall
2008-10-14 16:00 ` Julia Lawall
2008-10-14 16:30 ` Thomas Bogendoerfer [this message]
2008-10-14 16:30   ` Thomas Bogendoerfer
2008-10-14 16:40 ` Sam Creasey
2008-10-14 16:40   ` Sam Creasey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081014163007.GA9015@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sammy@sammy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.