From: Jarek Poplawski <jarkao2@gmail.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 00/14]: Killing qdisc->ops->requeue().
Date: Tue, 14 Oct 2008 21:15:54 +0200 [thread overview]
Message-ID: <20081014191554.GA2953@ami.dom.local> (raw)
In-Reply-To: <48F4CBBA.7070004@intel.com>
On Tue, Oct 14, 2008 at 09:41:30AM -0700, Alexander Duyck wrote:
...
> I think if anything it seems like you guys actually found the cpu
> performance issue a while back in the fact that the dev_requeue_skb was
> calling __netif_schedule when requeuing on a stopped queue. That is the
> one piece I would say needs to be changed so that you only call
> __netif_schedule if the skb is not going to a stopped queue.
BTW, since one of the other "dreams" of killing requeuing failed, I
think this proposal is worth checking, but David was concerned about
some issues with buggy drivers after __netif_schedule() removing.
Jarek P.
next prev parent reply other threads:[~2008-10-14 19:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 9:52 [PATCH 00/14]: Killing qdisc->ops->requeue() Jarek Poplawski
2008-10-14 11:39 ` Patrick McHardy
2008-10-14 12:26 ` Jarek Poplawski
2008-10-14 12:32 ` Patrick McHardy
2008-10-14 17:56 ` Jarek Poplawski
2008-10-14 20:18 ` David Miller
2008-10-14 20:44 ` Patrick McHardy
2008-10-15 8:27 ` Jarek Poplawski
2008-10-15 9:45 ` Patrick McHardy
2008-10-14 16:41 ` Alexander Duyck
2008-10-14 18:37 ` Jarek Poplawski
2008-10-14 18:41 ` Jarek Poplawski
2008-10-14 19:15 ` Jarek Poplawski [this message]
2008-10-14 20:37 ` Alexander Duyck
2008-10-15 6:45 ` Jarek Poplawski
2008-10-15 7:19 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014191554.GA2953@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.