All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Miller <mike.miller@hp.com>
Cc: JensAxboejens.axboe@oracle.com, alan.brunelle@hp.com,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] cciss: fix sysfs regression, obsoletes previous patch
Date: Thu, 16 Oct 2008 14:53:01 -0700	[thread overview]
Message-ID: <20081016145301.0d117cdf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081016212956.GA25704@roadking.ldev.net>

On Thu, 16 Oct 2008 16:29:56 -0500
Mike Miller <mike.miller@hp.com> wrote:

> 
> Patch 1 of 2
> 
> This patch obsoletes the one I sent yesterday. It fixes a broken symlink in
> sysfs. The previous patch appeared to work but was wrong as reported by Alan
> Brunelle.
> Please consider this for inclusion.
> 
> Signed-off-by: Mike Miller <mike.miller@hp.com>
> 
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 1e1f915..0f367b1 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
>  	disk->first_minor = drv_index << NWD_SHIFT;
>  	disk->fops = &cciss_fops;
>  	disk->private_data = &h->drv[drv_index];
> +	disk->driverfs_dev = &h->pdev->dev;
>  
>  	/* Set up queue information */
>  	blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);

Without knowing what caused this regression nor when it occurred, I am
unable to determine whether this fix is needed in 2.6.27.x.  Or indeed
2.6.26.x, etc.


      reply	other threads:[~2008-10-16 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 21:29 [PATCH 1/2] cciss: fix sysfs regression, obsoletes previous patch Mike Miller
2008-10-16 21:53 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081016145301.0d117cdf.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=JensAxboejens.axboe@oracle.com \
    --cc=alan.brunelle@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.