* [PATCH 1/2] cciss: fix sysfs regression, obsoletes previous patch
@ 2008-10-16 21:29 Mike Miller
2008-10-16 21:53 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Mike Miller @ 2008-10-16 21:29 UTC (permalink / raw)
To: Andrew Morton, JensAxboejens.axboe; +Cc: alan.brunelle, LKML, LKML-scsi
Patch 1 of 2
This patch obsoletes the one I sent yesterday. It fixes a broken symlink in
sysfs. The previous patch appeared to work but was wrong as reported by Alan
Brunelle.
Please consider this for inclusion.
Signed-off-by: Mike Miller <mike.miller@hp.com>
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 1e1f915..0f367b1 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
disk->first_minor = drv_index << NWD_SHIFT;
disk->fops = &cciss_fops;
disk->private_data = &h->drv[drv_index];
+ disk->driverfs_dev = &h->pdev->dev;
/* Set up queue information */
blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] cciss: fix sysfs regression, obsoletes previous patch
2008-10-16 21:29 [PATCH 1/2] cciss: fix sysfs regression, obsoletes previous patch Mike Miller
@ 2008-10-16 21:53 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2008-10-16 21:53 UTC (permalink / raw)
To: Mike Miller; +Cc: JensAxboejens.axboe, alan.brunelle, linux-kernel, linux-scsi
On Thu, 16 Oct 2008 16:29:56 -0500
Mike Miller <mike.miller@hp.com> wrote:
>
> Patch 1 of 2
>
> This patch obsoletes the one I sent yesterday. It fixes a broken symlink in
> sysfs. The previous patch appeared to work but was wrong as reported by Alan
> Brunelle.
> Please consider this for inclusion.
>
> Signed-off-by: Mike Miller <mike.miller@hp.com>
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 1e1f915..0f367b1 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1365,6 +1365,7 @@ static void cciss_add_disk(ctlr_info_t *h, struct gendisk *disk,
> disk->first_minor = drv_index << NWD_SHIFT;
> disk->fops = &cciss_fops;
> disk->private_data = &h->drv[drv_index];
> + disk->driverfs_dev = &h->pdev->dev;
>
> /* Set up queue information */
> blk_queue_bounce_limit(disk->queue, h->pdev->dma_mask);
Without knowing what caused this regression nor when it occurred, I am
unable to determine whether this fix is needed in 2.6.27.x. Or indeed
2.6.26.x, etc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-16 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-16 21:29 [PATCH 1/2] cciss: fix sysfs regression, obsoletes previous patch Mike Miller
2008-10-16 21:53 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.