Re: [PATCH] scsi: Fix bad use of udelay in atp870u.c

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 16 Oct 2008 10:21:46 +0200
Martin Michlmayr <tbm@cyrius.com> wrote:

> The ACARD driver calls udelay() with a value > 2000, which leads to
> to the following compilation error on ARM:
>   ERROR: "__bad_udelay" [drivers/scsi/atp870u.ko] undefined!
>   make[1]: *** [__modpost] Error 1
> Fix this by using a combination of mdelay and udelay.
> 
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> 
> --- a/drivers/scsi/atp870u.c
> +++ b/drivers/scsi/atp870u.c
> @@ -1171,7 +1171,8 @@ wait_io1:
>  	outw(val, tmport);
>  	outb(2, 0x80);
>  TCM_SYNC:
> -	udelay(0x800);
> +	mdelay(2);
> +	udelay(48);
>  	if ((inb(tmport) & 0x80) == 0x00) {	/* bsy ? */
>  		outw(0, tmport--);
>  		outb(0, tmport);
> 

hum.  The code has been like that for many years - why was the
error only discovered now.  Is that check in arm new?

If so, was it present in 2.6.27?
  If so, does anyone actually use this driver on arm?
    If so, we'll need this patch in 2.6.27.x as well.

?