Re: [PATCH] scsi: Fix bad use of udelay in atp870u.c

[Martin Michlmayr <tbm@cyrius.com>]

* Andrew Morton <akpm@linux-foundation.org> [2008-10-16 15:51]:
> > +	mdelay(2);
> > +	udelay(48);
> >  	if ((inb(tmport) & 0x80) == 0x00) {	/* bsy ? */
> >  		outw(0, tmport--);
> >  		outb(0, tmport);
> > 
> 
> hum.  The code has been like that for many years - why was the
> error only discovered now.  Is that check in arm new?

I don't think so.  I cannot remember for sure, but I probably ran into
it when we started moving the Debian ARM kernels from a config file
that only selected a limited number of modules to a more generic
config file that enables as much as possible.  I don't think anyone
cares about this one driver in particular, but it's hard to know which
modules users need, so we enable everything we can.

Anyway, we've carried a patch around since December 2007 that disables
this module on ARM because of this compilation error, but I'd like to
get this resolved in the mainline kernel.

> If so, was it present in 2.6.27?
>   If so, does anyone actually use this driver on arm?
>     If so, we'll need this patch in 2.6.27.x as well.

Nah, fixing it for 2.6.28 would be fine.
-- 
Martin Michlmayr
http://www.cyrius.com/